From: Pavel Machek <pavel@ucw.cz>
To: wuzhangjin@gmail.com
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org,
Arnaud Patard <apatard@mandriva.com>,
Atsushi Nemoto <anemo@mba.ocn.ne.jp>, yan hua <yanh@lemote.com>,
Zhang Fuxin <zhangfx@lemote.com>, Wu Zhangjin <wuzj@lemote.com>,
Hongbing Hu <huhb@lemote.com>
Subject: Re: [PATCH] Hibernation Support in mips system
Date: Wed, 3 Jun 2009 13:24:15 +0200 [thread overview]
Message-ID: <20090603112414.GF5084@elf.ucw.cz> (raw)
In-Reply-To: <1243956702-16276-1-git-send-email-wuzhangjin@gmail.com>
On Tue 2009-06-02 23:31:42, wuzhangjin@gmail.com wrote:
> From: Wu Zhangjin <wuzj@lemote.com>
>
> This is originally pulled from the to-mips branch of
> http://dev.lemote.com/code/linux_loongson, only a few coding style
> tuning under the support of script/checkpatch.pl
>
> as the feedback from Atsushi Nemoto,Yanhua and Pavel Machek, some changes
> have been done by Hu Hongbing(the original author of mips-specific STD)
> from Lemote.com. this patch apply the changes, which include:
>
> Reviewed-by: Pavel Machek <pavel@ucw.cz>
The patch looks ok, but I don't think I offered that tag before. You
can add it now.
> @@ -0,0 +1,31 @@
> +/*
> + * Suspend support specific for mips.
"Hibernation support"? Copyright, GPL, author info?
> +#include <linux/mm.h>
> +#include <linux/suspend.h>
> +#include <asm/mipsregs.h>
> +#include <asm/page.h>
> +#include <asm/suspend.h>
> +#include <asm/ptrace.h>
> +
> +static uint32_t saved_status;
"u32" please.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
prev parent reply other threads:[~2009-06-03 11:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 15:31 [PATCH] Hibernation Support in mips system wuzhangjin
2009-06-03 11:21 ` Ralf Baechle
2009-06-03 11:24 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090603112414.GF5084@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=anemo@mba.ocn.ne.jp \
--cc=apatard@mandriva.com \
--cc=huhb@lemote.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=wuzhangjin@gmail.com \
--cc=wuzj@lemote.com \
--cc=yanh@lemote.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox