From: Florian Fainelli <florian@openwrt.org>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH 0/5] Alchemy GPIO rewrite v6
Date: Thu, 4 Jun 2009 11:26:02 +0200 [thread overview]
Message-ID: <200906041126.02982.florian@openwrt.org> (raw)
In-Reply-To: <1244045888-16259-1-git-send-email-manuel.lauss@gmail.com>
Hi Manuel,
Le Wednesday 03 June 2009 18:18:03 Manuel Lauss, vous avez écrit :
> Rewrite Alchemy GPIO support to be compatible with the Linux
> GPIO framework, both with and without gpiolib. For a list of
> justifications, see blurb in patch #2.
> Patches #3-#5 replace a few open-coded GPIO accesses in the board
> files with calls to the new gpio functions.
>
> Tested on DB1200 and a custom Au1200 platform.
>
> v6 - renamed gpio.[ch] to gpio-au1000.[ch], since this code only affects
> pre-Au1300 chips. Should make integration of Au1300 GPIO a bit
> easier.
> v5 - fix gpio1 bug in inlined gpio_get_value()
> v4 - GPIO2 shared interrupt management, styling.
> v3 - fixed thinko in alchemy_gpio2_set_value (16->32 bit)
> v2 - added gpio_to_irq and irq_to_gpio, some renaming.
Thanks for this work ! For the whole serie you got my Acked-by: Florian
Fainelli <florian@openwrt.org>. Thanks !
>
> Manuel Lauss (5):
> Alchemy: remove unused au1000_gpio.h header
> Alchemy: rewrite GPIO support.
> Alchemy: mtx-1: use linux gpio api.
> Alchemy: xxs1500: use linux gpio api.
> Alchemy: devboards: convert to gpio calls.
>
> arch/mips/Makefile | 5 +-
> arch/mips/alchemy/Kconfig | 19 +-
> arch/mips/alchemy/common/Makefile | 11 +-
> arch/mips/alchemy/common/gpio-au1000.c | 130 +++++
> arch/mips/alchemy/common/gpio.c | 201 -------
> arch/mips/alchemy/common/reset.c | 5 +-
> arch/mips/alchemy/devboards/db1x00/board_setup.c | 8 +-
> arch/mips/alchemy/devboards/pb1000/board_setup.c | 10 +-
> arch/mips/alchemy/devboards/pb1100/board_setup.c | 3 +-
> arch/mips/alchemy/devboards/pb1500/board_setup.c | 10 +-
> arch/mips/alchemy/devboards/pm.c | 2 +-
> arch/mips/alchemy/mtx-1/board_setup.c | 24 +-
> arch/mips/alchemy/xxs1500/board_setup.c | 21 +-
> arch/mips/include/asm/mach-au1x00/au1000_gpio.h | 56 --
> arch/mips/include/asm/mach-au1x00/gpio-au1000.h | 604
> ++++++++++++++++++++++ arch/mips/include/asm/mach-au1x00/gpio.h |
> 35 +-
> 16 files changed, 818 insertions(+), 326 deletions(-)
> create mode 100644 arch/mips/alchemy/common/gpio-au1000.c
> delete mode 100644 arch/mips/alchemy/common/gpio.c
> delete mode 100644 arch/mips/include/asm/mach-au1x00/au1000_gpio.h
> create mode 100644 arch/mips/include/asm/mach-au1x00/gpio-au1000.h
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
prev parent reply other threads:[~2009-06-04 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-03 16:18 [PATCH 0/5] Alchemy GPIO rewrite v6 Manuel Lauss
2009-06-03 16:18 ` [PATCH 1/5] Alchemy: remove unused au1000_gpio.h header Manuel Lauss
2009-06-03 16:18 ` [PATCH 2/5] Alchemy: rewrite GPIO support Manuel Lauss
2009-06-03 16:18 ` [PATCH 3/5] Alchemy: mtx-1: use linux gpio api Manuel Lauss
2009-06-03 16:18 ` [PATCH 4/5] Alchemy: xxs1500: " Manuel Lauss
2009-06-03 16:18 ` [PATCH 5/5] Alchemy: devboards: convert to gpio calls Manuel Lauss
2009-06-04 9:26 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906041126.02982.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).