From: Florian Fainelli <florian@openwrt.org>
To: castet.matthieu@free.fr
Cc: wim@iguana.be, Linux Kernel list <linux-kernel@vger.kernel.org>,
linux-mips@linux-mips.org,
Aleksandar Radovanovic <biblbroks@sezampro.rs>
Subject: Re: add bcm47xx watchdog driver
Date: Sat, 6 Jun 2009 12:58:02 +0200 [thread overview]
Message-ID: <200906061258.04284.florian@openwrt.org> (raw)
In-Reply-To: <1244213922.4a2932a272094@imp.free.fr>
Le Friday 05 June 2009 16:58:42 castet.matthieu@free.fr, vous avez écrit :
> Hi Florian,
>
> Quoting Florian Fainelli <florian@openwrt.org>:
> > Your driver looks good, could you turn this into a platform device/driver
> > instead ? You declare bcm47xx_wdt_platform_device which is unused and you
> > also declare a MODULE_ALIAS which suggets it is one.
>
> What's the advantage of using platform device/driver ?
> Not all watchdog driver use it (for example softdog).
> This seems useless in this case because the driver don't have any resource,
> don't care about suspend/resume and add complexity in the code (2 registers
> in module probe, ...).
Indeed, I was suggesting that either you turn it into a full platform driver
or your remove references to it (bcm47xx_wdt_platform_device and
MODULE_ALIAS).
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
next prev parent reply other threads:[~2009-06-06 10:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-04 20:24 add bcm47xx watchdog driver matthieu castet
2009-06-05 13:58 ` Florian Fainelli
2009-06-05 14:58 ` castet.matthieu
2009-06-06 10:58 ` Florian Fainelli [this message]
2009-06-05 16:57 ` add bcm47xx watchdog driver v2 matthieu castet
2009-06-05 19:48 ` add bcm47xx watchdog driver Andrew Morton
2009-06-05 20:30 ` matthieu castet
2009-06-08 14:15 ` Florian Fainelli
2009-06-10 17:17 ` Wim Van Sebroeck
2009-06-10 18:47 ` matthieu castet
2009-06-10 19:06 ` Wim Van Sebroeck
2009-06-05 19:50 ` Andrew Morton
2009-06-05 20:03 ` matthieu castet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200906061258.04284.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=biblbroks@sezampro.rs \
--cc=castet.matthieu@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).