From: Ralf Baechle <ralf@linux-mips.org>
To: Alexey Zaytsev <zaytsev@altell.ru>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH] Make it compile.
Date: Fri, 12 Jun 2009 13:33:41 +0100 [thread overview]
Message-ID: <20090612123341.GA21878@linux-mips.org> (raw)
In-Reply-To: <4A30EE9B.30206@altell.ru>
On Thu, Jun 11, 2009 at 03:46:35PM +0400, Alexey Zaytsev wrote:
>>> diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
>>> index f69c6b5..222bed0 100644
>>> --- a/arch/mips/lib/delay.c
>>> +++ b/arch/mips/lib/delay.c
>>> @@ -51,6 +51,6 @@ void __ndelay(unsigned long ns)
>>> {
>>> unsigned int lpj = current_cpu_data.udelay_val;
>>> - __delay((us * 0x00000005 * HZ * lpj) >> 32);
>>> + __delay((ns * 0x00000005 * HZ * lpj) >> 32);
>>
>> This (and more) is already fixed by the patch posted by Atsushi
>> Nemoto.
> Thanks for noticing. I should really start reading the ml before
> sending any more patches. ;)
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
Obviously it doesn't scan for old patches ;-)
(and why would we believe such a statement sent over an insecure medium
anyway)
There is one open nit in the udelay rewrite which I'm about to fix now.
Cheers,
Ralf
prev parent reply other threads:[~2009-06-12 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 14:00 [PATCH] Make it compile Alexey Zaytsev
2009-06-10 14:15 ` Sergei Shtylyov
2009-06-11 11:46 ` Alexey Zaytsev
2009-06-12 12:33 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090612123341.GA21878@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
--cc=zaytsev@altell.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).