* [PATCH] Make it compile.
@ 2009-06-10 14:00 Alexey Zaytsev
2009-06-10 14:15 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Zaytsev @ 2009-06-10 14:00 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-mips
Signed-off-by: Alexey Zaytsev <zaytsev@altell.ru>
---
arch/mips/lib/delay.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
index f69c6b5..222bed0 100644
--- a/arch/mips/lib/delay.c
+++ b/arch/mips/lib/delay.c
@@ -51,6 +51,6 @@ void __ndelay(unsigned long ns)
{
unsigned int lpj = current_cpu_data.udelay_val;
- __delay((us * 0x00000005 * HZ * lpj) >> 32);
+ __delay((ns * 0x00000005 * HZ * lpj) >> 32);
}
EXPORT_SYMBOL(__ndelay);
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Make it compile.
2009-06-10 14:00 [PATCH] Make it compile Alexey Zaytsev
@ 2009-06-10 14:15 ` Sergei Shtylyov
2009-06-11 11:46 ` Alexey Zaytsev
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2009-06-10 14:15 UTC (permalink / raw)
To: Alexey Zaytsev; +Cc: Ralf Baechle, linux-mips
Hello.
Alexey Zaytsev wrote:
> Signed-off-by: Alexey Zaytsev <zaytsev@altell.ru>
> diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
> index f69c6b5..222bed0 100644
> --- a/arch/mips/lib/delay.c
> +++ b/arch/mips/lib/delay.c
> @@ -51,6 +51,6 @@ void __ndelay(unsigned long ns)
> {
> unsigned int lpj = current_cpu_data.udelay_val;
>
> - __delay((us * 0x00000005 * HZ * lpj) >> 32);
> + __delay((ns * 0x00000005 * HZ * lpj) >> 32);
This (and more) is already fixed by the patch posted by Atsushi Nemoto.
> }
> EXPORT_SYMBOL(__ndelay);
WBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Make it compile.
2009-06-10 14:15 ` Sergei Shtylyov
@ 2009-06-11 11:46 ` Alexey Zaytsev
2009-06-12 12:33 ` Ralf Baechle
0 siblings, 1 reply; 4+ messages in thread
From: Alexey Zaytsev @ 2009-06-11 11:46 UTC (permalink / raw)
To: Sergei Shtylyov; +Cc: Ralf Baechle, linux-mips
Sergei Shtylyov wrote:
> Hello.
>
> Alexey Zaytsev wrote:
>
>> Signed-off-by: Alexey Zaytsev <zaytsev@altell.ru>
>
>> diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
>> index f69c6b5..222bed0 100644
>> --- a/arch/mips/lib/delay.c
>> +++ b/arch/mips/lib/delay.c
>> @@ -51,6 +51,6 @@ void __ndelay(unsigned long ns)
>> {
>> unsigned int lpj = current_cpu_data.udelay_val;
>>
>> - __delay((us * 0x00000005 * HZ * lpj) >> 32);
>> + __delay((ns * 0x00000005 * HZ * lpj) >> 32);
>
> This (and more) is already fixed by the patch posted by Atsushi
> Nemoto.
Thanks for noticing. I should really start reading the ml before
sending any more patches. ;)
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Make it compile.
2009-06-11 11:46 ` Alexey Zaytsev
@ 2009-06-12 12:33 ` Ralf Baechle
0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2009-06-12 12:33 UTC (permalink / raw)
To: Alexey Zaytsev; +Cc: Sergei Shtylyov, linux-mips
On Thu, Jun 11, 2009 at 03:46:35PM +0400, Alexey Zaytsev wrote:
>>> diff --git a/arch/mips/lib/delay.c b/arch/mips/lib/delay.c
>>> index f69c6b5..222bed0 100644
>>> --- a/arch/mips/lib/delay.c
>>> +++ b/arch/mips/lib/delay.c
>>> @@ -51,6 +51,6 @@ void __ndelay(unsigned long ns)
>>> {
>>> unsigned int lpj = current_cpu_data.udelay_val;
>>> - __delay((us * 0x00000005 * HZ * lpj) >> 32);
>>> + __delay((ns * 0x00000005 * HZ * lpj) >> 32);
>>
>> This (and more) is already fixed by the patch posted by Atsushi
>> Nemoto.
> Thanks for noticing. I should really start reading the ml before
> sending any more patches. ;)
>
>
> --
> This message has been scanned for viruses and
> dangerous content by MailScanner, and is
> believed to be clean.
Obviously it doesn't scan for old patches ;-)
(and why would we believe such a statement sent over an insecure medium
anyway)
There is one open nit in the udelay rewrite which I'm about to fix now.
Cheers,
Ralf
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-12 12:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-10 14:00 [PATCH] Make it compile Alexey Zaytsev
2009-06-10 14:15 ` Sergei Shtylyov
2009-06-11 11:46 ` Alexey Zaytsev
2009-06-12 12:33 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).