* [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h
@ 2009-06-14 6:52 Wu Zhangjin
2009-06-14 12:34 ` Frederic Weisbecker
0 siblings, 1 reply; 2+ messages in thread
From: Wu Zhangjin @ 2009-06-14 6:52 UTC (permalink / raw)
To: Frederic Weisbecker, linux-kernel, Linux-MIPS
Cc: Steven Rostedt, Ralf Baechle, Pekka Enberg, Wu Zhangjin
From: Wu Zhangjin <wuzj@lemote.com>
when compiling linux-mips with kmemtrace enabled, there will be an
error:
include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
a function)
I checked the source code and found trace_seq.h used PAGE_SIZE but not
included the relative header file, so, fix it via adding the header file
<asm/page.h>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
---
include/linux/trace_seq.h | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
index c68bccb..c134dd1 100644
--- a/include/linux/trace_seq.h
+++ b/include/linux/trace_seq.h
@@ -3,6 +3,8 @@
#include <linux/fs.h>
+#include <asm/page.h>
+
/*
* Trace sequences are used to allow a function to call several other functions
* to create a string of data to use (up to a max of PAGE_SIZE.
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h
2009-06-14 6:52 [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h Wu Zhangjin
@ 2009-06-14 12:34 ` Frederic Weisbecker
0 siblings, 0 replies; 2+ messages in thread
From: Frederic Weisbecker @ 2009-06-14 12:34 UTC (permalink / raw)
To: Wu Zhangjin
Cc: linux-kernel, Linux-MIPS, Steven Rostedt, Ralf Baechle,
Pekka Enberg, Wu Zhangjin, Ingo Molnar
On Sun, Jun 14, 2009 at 02:52:30PM +0800, Wu Zhangjin wrote:
> From: Wu Zhangjin <wuzj@lemote.com>
>
> when compiling linux-mips with kmemtrace enabled, there will be an
> error:
>
> include/linux/trace_seq.h:12: error: 'PAGE_SIZE' undeclared here (not in
> a function)
>
> I checked the source code and found trace_seq.h used PAGE_SIZE but not
> included the relative header file, so, fix it via adding the header file
> <asm/page.h>
>
> Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> Signed-off-by: Wu Zhangjin <wuzj@lemote.com>
Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> include/linux/trace_seq.h | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/trace_seq.h b/include/linux/trace_seq.h
> index c68bccb..c134dd1 100644
> --- a/include/linux/trace_seq.h
> +++ b/include/linux/trace_seq.h
> @@ -3,6 +3,8 @@
>
> #include <linux/fs.h>
>
> +#include <asm/page.h>
> +
> /*
> * Trace sequences are used to allow a function to call several other functions
> * to create a string of data to use (up to a max of PAGE_SIZE.
> --
> 1.6.0.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-06-14 12:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-14 6:52 [PATCH] tracing: fix undeclared 'PAGE_SIZE' in include/linux/trace_seq.h Wu Zhangjin
2009-06-14 12:34 ` Frederic Weisbecker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).