* [PATCH 54/64] mips: remove driver_data direct access of struct device
[not found] <20090616051351.GA23627@kroah.com>
@ 2009-06-16 5:46 ` Greg Kroah-Hartman
2009-06-16 9:31 ` Ralf Baechle
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2009-06-16 5:46 UTC (permalink / raw)
To: linux-kernel; +Cc: Greg Kroah-Hartman, linux-mips, Ralf Baechle
In the near future, the driver core is going to not allow direct access
to the driver_data pointer in struct device. Instead, the functions
dev_get_drvdata() and dev_set_drvdata() should be used. These functions
have been around since the beginning, so are backwards compatible with
all older kernel versions.
Cc: linux-mips@linux-mips.org
Cc: Ralf Baechle <ralf@linux-mips.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
arch/mips/sni/eisa.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/mips/sni/eisa.c b/arch/mips/sni/eisa.c
index 7396cd7..6827feb 100644
--- a/arch/mips/sni/eisa.c
+++ b/arch/mips/sni/eisa.c
@@ -38,7 +38,7 @@ int __init sni_eisa_root_init(void)
if (!r)
return r;
- eisa_root_dev.dev.driver_data = &eisa_bus_root;
+ dev_set_drvdata(&eisa_root_dev.dev, &eisa_bus_root);
if (eisa_root_register(&eisa_bus_root)) {
/* A real bridge may have been registered before
--
1.6.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 54/64] mips: remove driver_data direct access of struct device
2009-06-16 5:46 ` [PATCH 54/64] mips: remove driver_data direct access of struct device Greg Kroah-Hartman
@ 2009-06-16 9:31 ` Ralf Baechle
2009-06-16 16:25 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Ralf Baechle @ 2009-06-16 9:31 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: linux-kernel, linux-mips
On Mon, Jun 15, 2009 at 10:46:43PM -0700, Greg Kroah-Hartman wrote:
> In the near future, the driver core is going to not allow direct access
> to the driver_data pointer in struct device. Instead, the functions
> dev_get_drvdata() and dev_set_drvdata() should be used. These functions
> have been around since the beginning, so are backwards compatible with
> all older kernel versions.
>
> Cc: linux-mips@linux-mips.org
> Cc: Ralf Baechle <ralf@linux-mips.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 54/64] mips: remove driver_data direct access of struct device
2009-06-16 9:31 ` Ralf Baechle
@ 2009-06-16 16:25 ` Greg KH
0 siblings, 0 replies; 3+ messages in thread
From: Greg KH @ 2009-06-16 16:25 UTC (permalink / raw)
To: Ralf Baechle; +Cc: linux-kernel, linux-mips
On Tue, Jun 16, 2009 at 10:31:34AM +0100, Ralf Baechle wrote:
> On Mon, Jun 15, 2009 at 10:46:43PM -0700, Greg Kroah-Hartman wrote:
>
> > In the near future, the driver core is going to not allow direct access
> > to the driver_data pointer in struct device. Instead, the functions
> > dev_get_drvdata() and dev_set_drvdata() should be used. These functions
> > have been around since the beginning, so are backwards compatible with
> > all older kernel versions.
> >
> > Cc: linux-mips@linux-mips.org
> > Cc: Ralf Baechle <ralf@linux-mips.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
>
> Thanks, applied.
Heh, I sent this a while ago to you :)
This was the "here's what just got sent to Linus" series of patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-06-16 16:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20090616051351.GA23627@kroah.com>
2009-06-16 5:46 ` [PATCH 54/64] mips: remove driver_data direct access of struct device Greg Kroah-Hartman
2009-06-16 9:31 ` Ralf Baechle
2009-06-16 16:25 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).