From: Ralf Baechle <ralf@linux-mips.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Frank Seidel <Frank.Seidel@sphairon.com>,
linux-mips@linux-mips.org, netdev@vger.kernel.org
Subject: [PATCH] linux-2.4: vlan: Slab memleak fix
Date: Mon, 29 Jun 2009 16:43:27 +0100 [thread overview]
Message-ID: <20090629154325.GB18570@linux-mips.org> (raw)
From: Arne Redlich <readlicha@sphairon.com>
Fix slab memleak on wan service restart
Signed-off-by: Arne Redlich <redlicha@sphairon.com>
Signed-off-by: Frank Seidel <Frank.Seidel@sphairon.com>
Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
---
net/8021q/vlan_dev.c | 22 +++++++++++++++++++++-
1 file changed, 21 insertions(+), 1 deletion(-)
--- a/net/8021q/vlan_dev.c
+++ b/net/8021q/vlan_dev.c
@@ -548,6 +548,22 @@ int vlan_dev_set_ingress_priority(char *
return -EINVAL;
}
+/* Remove all egress_priority_map hash table entries. --redlicha */
+static void vlan_dev_destroy_egress_priority_map(struct net_device *dev)
+{
+ struct vlan_dev_info *info = VLAN_DEV_INFO(dev);
+ struct vlan_priority_tci_mapping *m;
+ int i;
+
+ for (i = 0; i < ARRAY_SIZE(info->egress_priority_map); i++) {
+ while ((m = info->egress_priority_map[i])) {
+ info->egress_priority_map[i] =
+ info->egress_priority_map[i]->next;
+ kfree(m);
+ }
+ }
+}
+
int vlan_dev_set_egress_priority(char *dev_name, __u32 skb_prio, short vlan_prio)
{
struct net_device *dev = dev_get_by_name(dev_name);
@@ -826,7 +842,11 @@ void vlan_dev_destruct(struct net_device
if (dev->priv) {
if (VLAN_DEV_INFO(dev)->dent)
BUG();
-
+ /*
+ * Don't leak the hash table entries in
+ * VLAN_DEV_INFO(dev)->egress_priority_map! --redlicha
+ */
+ vlan_dev_destroy_egress_priority_map(dev);
kfree(dev->priv);
dev->priv = NULL;
}
next reply other threads:[~2009-06-29 15:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 15:43 Ralf Baechle [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-06-29 12:21 [PATCH] linux-2.4: vlan: Slab memleak fix Frank Seidel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090629154325.GB18570@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=Frank.Seidel@sphairon.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).