From: Florian Fainelli <florian@openwrt.org>
To: Shane McDonald <mcdonald.shane@gmail.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: [PATCH] fix build failures on msp_irq_slp.c
Date: Sun, 12 Jul 2009 18:42:07 +0200 [thread overview]
Message-ID: <200907121842.08739.florian@openwrt.org> (raw)
In-Reply-To: <b2b2f2320907120934x6d6e4059ma318fe6236e45b19@mail.gmail.com>
Le Sunday 12 July 2009 18:34:45 Shane McDonald, vous avez écrit :
> On Sat, Jul 11, 2009 at 4:51 AM, Shane McDonald
<mcdonald.shane@gmail.com>wrote:
> > Hi Florian:
> >
> > My apologies for the delay in replying to your latest prompt -- I've
> > been on vacation with little internet access.
> >
> > Your patch looks correct to me, but as Ralf says, the existing code is
> > a little suspect. In my poking around, I've come across three different
> > versions of this file: the in-tree version, the latest out-of-tree patch
> > from PMC-Sierra, and an unreleased version from a colleague. None appear
> > to be quite correct. I think I've got enough info, though, to come up
> > with a good version.
> >
> > I'll cook something up this weekend and get it posted.
>
> OK, I've done my cooking, and the cleanup patch will follow in a separate
> email. It expects Florian's patch to have been applied.
Thank you very much !
>
> Florian's patch is correct, so I'll add my:
>
> Acked-by: Shane McDonald <mcdonald.shane@gmail.com>
>
> Shane
--
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------
next prev parent reply other threads:[~2009-07-12 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-27 14:59 [PATCH] fix build failures on msp_irq_slp.c Florian Fainelli
2009-04-29 11:58 ` Ralf Baechle
2009-04-29 13:12 ` Florian Fainelli
2009-04-29 14:18 ` Shane McDonald
2009-06-28 5:01 ` Florian Fainelli
2009-07-11 10:51 ` Shane McDonald
2009-07-12 16:34 ` Shane McDonald
2009-07-12 16:42 ` Florian Fainelli [this message]
2009-07-13 11:53 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907121842.08739.florian@openwrt.org \
--to=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=mcdonald.shane@gmail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).