* [PATCH] Simplify and correct interrupt handling for MSP4200
@ 2009-07-12 16:42 Shane McDonald
2009-07-13 12:10 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Shane McDonald @ 2009-07-12 16:42 UTC (permalink / raw)
To: Andrew_Hughes, florian, linux-mips, Marc_St-Jean, ralf
The current interrupt handling code for the MSP4200 always
masks an interrupt before acknowledging it. This is not required,
as that will be handled by the level interrupt handler. This
change simplifies the MSP4200 code to remove the masking in the
ack routine, and makes sure that the minimum required operation
is performed for masking and acking, rather than always both
masking and acking the interrupt.
Signed-off-by: Shane McDonald <mcdonald.shane@gmail.com>
---
arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
diff --git a/arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c b/arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c
index 66f6f85..61f3902 100644
--- a/arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c
+++ b/arch/mips/pmc-sierra/msp71xx/msp_irq_slp.c
@@ -45,13 +45,6 @@ static inline void mask_msp_slp_irq(unsigned int irq)
*/
static inline void ack_msp_slp_irq(unsigned int irq)
{
- mask_msp_slp_irq(irq);
-
- /*
- * only really necessary for 18, 16-14 and sometimes 3:0 (since
- * these can be edge sensitive) but it doesn't hurt for the others.
- */
-
/* check for PER interrupt range */
if (irq < MSP_PER_INTBASE)
*SLP_INT_STS_REG = (1 << (irq - MSP_SLP_INTBASE));
@@ -62,8 +55,7 @@ static inline void ack_msp_slp_irq(unsigned int irq)
static struct irq_chip msp_slp_irq_controller = {
.name = "MSP_SLP",
.ack = ack_msp_slp_irq,
- .mask = ack_msp_slp_irq,
- .mask_ack = ack_msp_slp_irq,
+ .mask = mask_msp_slp_irq,
.unmask = unmask_msp_slp_irq,
};
--
1.6.2.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Simplify and correct interrupt handling for MSP4200
2009-07-12 16:42 [PATCH] Simplify and correct interrupt handling for MSP4200 Shane McDonald
@ 2009-07-13 12:10 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2009-07-13 12:10 UTC (permalink / raw)
To: Shane McDonald; +Cc: Andrew_Hughes, florian, linux-mips, Marc_St-Jean
On Sun, Jul 12, 2009 at 10:42:06AM -0600, Shane McDonald wrote:
Thanks, applied.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-07-13 12:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-12 16:42 [PATCH] Simplify and correct interrupt handling for MSP4200 Shane McDonald
2009-07-13 12:10 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).