From: Frans Pop <elendil@planet.nl>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org,
manuel.lauss@gmail.com
Subject: Re: [PATCH] au1xmmc: dev_pm_ops conversion
Date: Tue, 21 Jul 2009 16:48:43 +0200 [thread overview]
Message-ID: <200907211648.44433.elendil@planet.nl> (raw)
In-Reply-To: <f861ec6f0907202212h4b28982fjcb9787a3915d7ee7@mail.gmail.com>
On Tuesday 21 July 2009, Manuel Lauss wrote:
> >> -#ifdef CONFIG_PM
> >
> > Won't the removal of this test cause a build failure if CONFIG_PM is
> > not set? If the removal of the test is safe, this should IMHO at
> > least be explained in the commit message.
>
> No, it builds just fine without CONFIG_PM; it was there to shave off a
> few bytes from the kernel image. But not everyone tests this driver
> with CONFIG_PM=y, because apparently noone really needed PM on
> this platform (Alchemy), and a full build of most of the boards using
> this driver fails with PM enabled.
OK.
> This way the PM methods at least get a compile-test in the non-pm case.
Not sure that is a sufficiently valid argument. In any case it *is* a
separate change to "dev_pm_ops conversion" so it really should at least
be documented and justified in the commit log.
> I like what Magnus Damm did for some of the SuperH drivers:
>
> #ifdef CONFIG_PM
> [...]
> #define DRIVER_PM_OPS (&driver_pm_ops)
> #else
> #define DRIVER_PM_OPS NULL
> #endif
Yes, that's quite elegant.
> I'd like to keep the pm stuff enabled at all times since it doesn't
> hurt in the non-pm case and if kernel size becomes a problem I can add
> the #defines back.
I guess that's up to the maintainers of the mips port.
Cheers,
FJP
prev parent reply other threads:[~2009-07-21 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-20 18:51 [PATCH] au1xmmc: dev_pm_ops conversion Manuel Lauss
2009-07-20 18:51 ` [PATCH] au1xmmc: allow platforms to disable certain host capabilities Manuel Lauss
2009-07-20 20:00 ` [PATCH] au1xmmc: dev_pm_ops conversion Frans Pop
2009-07-21 5:12 ` Manuel Lauss
2009-07-21 14:48 ` Frans Pop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200907211648.44433.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).