[PATCH] MIPS: Octeon: Run IPI code with interrupts disabled.

[PATCH] MIPS: Octeon: Run IPI code with interrupts disabled.

[David Daney]

In mm/slab.c the function do_ccupdate_local requires that interrupts
be disabled.  If they are not, we panic with CONFIG_DEBUG_SLAB.

So we disable interrupts while processing IPIs.  Also these are not
shared irqs, so get rid of the IRQF_SHARED flag.

Signed-off-by: David Daney <ddaney@caviumnetworks.com>
---
 arch/mips/cavium-octeon/smp.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index 0b891a9..32d51a3 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -194,11 +194,11 @@ static void octeon_init_secondary(void)
 void octeon_prepare_cpus(unsigned int max_cpus)
 {
 	cvmx_write_csr(CVMX_CIU_MBOX_CLRX(cvmx_get_core_num()), 0xffffffff);
-	if (request_irq(OCTEON_IRQ_MBOX0, mailbox_interrupt, IRQF_SHARED,
+	if (request_irq(OCTEON_IRQ_MBOX0, mailbox_interrupt, IRQF_DISABLED,
 			"mailbox0", mailbox_interrupt)) {
 		panic("Cannot request_irq(OCTEON_IRQ_MBOX0)\n");
 	}
-	if (request_irq(OCTEON_IRQ_MBOX1, mailbox_interrupt, IRQF_SHARED,
+	if (request_irq(OCTEON_IRQ_MBOX1, mailbox_interrupt, IRQF_DISABLED,
 			"mailbox1", mailbox_interrupt)) {
 		panic("Cannot request_irq(OCTEON_IRQ_MBOX1)\n");
 	}
-- 
1.6.0.6

Re: [PATCH] MIPS: Octeon: Run IPI code with interrupts disabled.

[Ralf Baechle]

On Fri, Jul 31, 2009 at 02:30:07PM -0700, David Daney wrote:

> In mm/slab.c the function do_ccupdate_local requires that interrupts
> be disabled.  If they are not, we panic with CONFIG_DEBUG_SLAB.
> 
> So we disable interrupts while processing IPIs.  Also these are not
> shared irqs, so get rid of the IRQF_SHARED flag.

Yes, this one will ruin your day.

  Ralf