From: Alexander Clouter <alex@digriz.org.uk>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] ar7: register watchdog driver only if enabled in hardware configuration
Date: Wed, 5 Aug 2009 09:34:11 +0100 [thread overview]
Message-ID: <20090805083411.GD31078@chipmunk> (raw)
In-Reply-To: <4A79407B.7070604@ru.mvista.com>
Hi,
* Sergei Shtylyov <sshtylyov@ru.mvista.com> [2009-08-05 12:19:07+0400]:
>
> Hello.
>
> Alexander Clouter wrote:
>
> > I think the 'correct' way to do this is:
> > ---
> > void __iomem *bootcr;
> > u32 val;
> >
> > ...
> >
> > bootcr = ioremap_nocache(AR7_REGS_DCL, 4);
> > val = *bootcr;
> >
>
> Wait, you can't dereference a pointer to void...
>
bah,
----
val = __raw_readl(bootcr);
----
Cheers
--
Alexander Clouter
.sigmonster says: If you keep anything long enough, you can throw it away.
next prev parent reply other threads:[~2009-08-05 8:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 21:09 [PATCH] ar7: register watchdog driver only if enabled in hardware configuration Florian Fainelli
2009-08-04 22:41 ` Alexander Clouter
2009-08-05 8:19 ` Sergei Shtylyov
2009-08-05 8:34 ` Alexander Clouter [this message]
2009-08-05 8:00 ` Alexander Clouter
2009-08-07 17:27 ` Florian Fainelli
2009-10-05 9:40 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090805083411.GD31078@chipmunk \
--to=alex@digriz.org.uk \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).