Re: [PATCH 2/2] bcm63xx: only set the proper GPIO overlay settings

[Florian Fainelli <florian@openwrt.org>]

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

Le lundi 31 août 2009 22:26:29, Maxime Bizon a écrit :
> On Mon, 2009-08-31 at 20:28 +0200, Florian Fainelli wrote:
> > This patch makes the GPIO pin multiplexing configuration
> > read the initial GPIO mode register value instead of
> > setting it initially to 0, then setting the correct
> > bits, this is safer.
>
> I disagree, now we get working or not working devices depending on the
> CFE version used, for which we don't have any public source code nor
> changelog.

I did not think this could break other boards, it is required on BCM6345 
though.

>
> I cleared the register for that purpose.
>
> If a particular pin muxing config is needed for some board, we should
> add this to the board specific struct instead.

Then I will make it BCM6345 specific.

Thanks.
-- 
Best regards, Florian Fainelli
Email: florian@openwrt.org
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 201 bytes --]