From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sun, 13 Sep 2009 16:26:04 +0200 (CEST) Received: from mba.ocn.ne.jp ([122.28.14.163]:64066 "HELO smtp.mba.ocn.ne.jp" rhost-flags-OK-OK-OK-OK) by ftp.linux-mips.org with SMTP id S1492464AbZIMOZ5 (ORCPT ); Sun, 13 Sep 2009 16:25:57 +0200 Received: from localhost (p5010-ipad310funabasi.chiba.ocn.ne.jp [123.217.207.10]) by smtp.mba.ocn.ne.jp (Postfix) with ESMTP id 4A1466699; Sun, 13 Sep 2009 23:25:48 +0900 (JST) Date: Sun, 13 Sep 2009 23:25:48 +0900 (JST) Message-Id: <20090913.232548.253168283.anemo@mba.ocn.ne.jp> To: julia@diku.dk Cc: ralf@linux-mips.org, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 1/8] arch/mips/txx9: introduce missing kfree, iounmap From: Atsushi Nemoto In-Reply-To: References: X-Fingerprint: 6ACA 1623 39BD 9A94 9B1A B746 CA77 FE94 2874 D52F X-Pgp-Public-Key: http://wwwkeys.pgp.net/pks/lookup?op=get&search=0x2874D52F X-Mailer: Mew version 5.2 on Emacs 22.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 24024 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: anemo@mba.ocn.ne.jp Precedence: bulk X-list: linux-mips On Fri, 11 Sep 2009 18:21:00 +0200 (CEST), Julia Lawall wrote: > From: Julia Lawall > > Error handling code following a kzalloc should free the allocated data. > Error handling code following an ioremap should iounmap the allocated data. > > The semantic match that finds the first problem is as follows: > (http://www.emn.fr/x-info/coccinelle/) Thank you for finding this out. This patch add some correctness, but obviously incomplete: there are more error pathes without iounmap/kfree/etc. in this function. And I like goto-style cleanup, as Mark Brown said in reply for your sound/soc patch. Could you make a new patch? --- Atsushi Nemoto