From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Sat, 10 Oct 2009 17:35:36 +0200 (CEST) Received: from bhuna.collabora.co.uk ([93.93.128.226]:49135 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by ftp.linux-mips.org with ESMTP id S1492843AbZJJPf3 (ORCPT ); Sat, 10 Oct 2009 17:35:29 +0200 Received: from mycelium.queued.net (wireless.queued.net [66.92.71.179]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id D79AD600AB7; Sat, 10 Oct 2009 16:35:17 +0100 (BST) Date: Sat, 10 Oct 2009 11:34:36 -0400 From: Andres Salomon To: wuzhangjin@gmail.com Cc: Linux Kernel Mailing List , linux-mips , Jaya Kumar , Jaroslav Kysela , loongson-dev@googlegroups.com Subject: Re: [PATCH] CS5535: Remove the X86 platform dependence of SND_CS5535AUDIO Message-ID: <20091010113436.2bfa0bb6@mycelium.queued.net> In-Reply-To: <1255185134.6883.20.camel@falcon> References: <1255059842-12160-1-git-send-email-wuzhangjin@gmail.com> <1255060287.16819.1.camel@falcon> <20091009005318.7174938c@mycelium.queued.net> <1255185134.6883.20.camel@falcon> X-Mailer: Claws Mail 3.7.2 (GTK+ 2.18.0; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 24215 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: dilinger@collabora.co.uk Precedence: bulk X-list: linux-mips On Sat, 10 Oct 2009 22:32:14 +0800 Wu Zhangjin wrote: > Hello, > > On Fri, 2009-10-09 at 00:53 -0400, Andres Salomon wrote: > > On Fri, 09 Oct 2009 11:51:27 +0800 > > Wu Zhangjin wrote: > > > > > On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote: > > > > There is no platform dependence of SND_CS5535AUDIO before > > > > 2.6.31, Not sure who have touched this part, but > > > > SND_CS5535AUDIO is at least available on Loongson family > > > > machines, so, Remove the platform dependence directly. > > > > > > > > Reported-by: rixed@happyleptic.org > > > > Signed-off-by: Wu Zhangjin > > > > --- > > > > sound/pci/Kconfig | 1 - > > > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig > > > > index fb5ee3c..75c602b 100644 > > > > --- a/sound/pci/Kconfig > > > > +++ b/sound/pci/Kconfig > > > > @@ -259,7 +259,6 @@ config SND_CS5530 > > > > > > > > config SND_CS5535AUDIO > > > > tristate "CS5535/CS5536 Audio" > > > > - depends on X86 && !X86_64 > > > [...] > > Just checked the SND_CS5536AUDIO(=y and =m) option with ARCH=x86_64, > no compiling warnings & errors, but I don't have such a chip in a > x86-64 machine, so, did not test the kernel yet. > > Regards, > Wu Zhangjin > Great, feel free to add Acked-by: Andres Salomon From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bhuna.collabora.co.uk ([93.93.128.226]:49135 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by ftp.linux-mips.org with ESMTP id S1492843AbZJJPf3 (ORCPT ); Sat, 10 Oct 2009 17:35:29 +0200 Date: Sat, 10 Oct 2009 11:34:36 -0400 From: Andres Salomon Subject: Re: [PATCH] CS5535: Remove the X86 platform dependence of SND_CS5535AUDIO Message-ID: <20091010113436.2bfa0bb6@mycelium.queued.net> In-Reply-To: <1255185134.6883.20.camel@falcon> References: <1255059842-12160-1-git-send-email-wuzhangjin@gmail.com> <1255060287.16819.1.camel@falcon> <20091009005318.7174938c@mycelium.queued.net> <1255185134.6883.20.camel@falcon> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-Path: Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org To: wuzhangjin@gmail.com Cc: Linux Kernel Mailing List , linux-mips , Jaya Kumar , Jaroslav Kysela , loongson-dev@googlegroups.com Message-ID: <20091010153436.IteRcB-07x6ENOdFgkaaiYrlFvCZD9vXWcqJ23BUGo8@z> On Sat, 10 Oct 2009 22:32:14 +0800 Wu Zhangjin wrote: > Hello, > > On Fri, 2009-10-09 at 00:53 -0400, Andres Salomon wrote: > > On Fri, 09 Oct 2009 11:51:27 +0800 > > Wu Zhangjin wrote: > > > > > On Fri, 2009-10-09 at 11:44 +0800, Wu Zhangjin wrote: > > > > There is no platform dependence of SND_CS5535AUDIO before > > > > 2.6.31, Not sure who have touched this part, but > > > > SND_CS5535AUDIO is at least available on Loongson family > > > > machines, so, Remove the platform dependence directly. > > > > > > > > Reported-by: rixed@happyleptic.org > > > > Signed-off-by: Wu Zhangjin > > > > --- > > > > sound/pci/Kconfig | 1 - > > > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > > > > > diff --git a/sound/pci/Kconfig b/sound/pci/Kconfig > > > > index fb5ee3c..75c602b 100644 > > > > --- a/sound/pci/Kconfig > > > > +++ b/sound/pci/Kconfig > > > > @@ -259,7 +259,6 @@ config SND_CS5530 > > > > > > > > config SND_CS5535AUDIO > > > > tristate "CS5535/CS5536 Audio" > > > > - depends on X86 && !X86_64 > > > [...] > > Just checked the SND_CS5536AUDIO(=y and =m) option with ARCH=x86_64, > no compiling warnings & errors, but I don't have such a chip in a > x86-64 machine, so, did not test the kernel yet. > > Regards, > Wu Zhangjin > Great, feel free to add Acked-by: Andres Salomon