* [PATCH] MIPS: Alchemy: reduce size of irq dispatcher
@ 2009-10-13 18:26 Manuel Lauss
2009-10-13 19:46 ` Ralf Baechle
0 siblings, 1 reply; 2+ messages in thread
From: Manuel Lauss @ 2009-10-13 18:26 UTC (permalink / raw)
To: Ralf Baechle, Linux-MIPS; +Cc: Manuel Lauss
By replacing an extra do_IRQ with a goto, the assembly shrinks
from 260 to 212 bytes (gcc-4.3.4).
Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
---
Applies on top of the irq changes in -queue.
arch/mips/alchemy/common/irq.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/arch/mips/alchemy/common/irq.c b/arch/mips/alchemy/common/irq.c
index ab65997..b2a1e4e 100644
--- a/arch/mips/alchemy/common/irq.c
+++ b/arch/mips/alchemy/common/irq.c
@@ -501,8 +501,8 @@ asmlinkage void plat_irq_dispatch(void)
unsigned long s, off;
if (pending & CAUSEF_IP7) {
- do_IRQ(MIPS_CPU_IRQ_BASE + 7);
- return;
+ off = MIPS_CPU_IRQ_BASE + 7;
+ goto handle;
} else if (pending & CAUSEF_IP2) {
s = IC0_REQ0INT;
off = AU1000_INTC0_INT_BASE;
@@ -524,7 +524,9 @@ spurious:
spurious_interrupt();
return;
}
- do_IRQ(__ffs(s) + off);
+ off += __ffs(s);
+handle:
+ do_IRQ(off);
}
/* setup edge/level and assign request 0/1 */
--
1.6.5.rc2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] MIPS: Alchemy: reduce size of irq dispatcher
2009-10-13 18:26 [PATCH] MIPS: Alchemy: reduce size of irq dispatcher Manuel Lauss
@ 2009-10-13 19:46 ` Ralf Baechle
0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2009-10-13 19:46 UTC (permalink / raw)
To: Manuel Lauss; +Cc: Linux-MIPS, Manuel Lauss
On Tue, Oct 13, 2009 at 08:26:31PM +0200, Manuel Lauss wrote:
> By replacing an extra do_IRQ with a goto, the assembly shrinks
> from 260 to 212 bytes (gcc-4.3.4).
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> Applies on top of the irq changes in -queue.
Thanks, queued for 2.6.33.
Ralf
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-10-13 19:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-13 18:26 [PATCH] MIPS: Alchemy: reduce size of irq dispatcher Manuel Lauss
2009-10-13 19:46 ` Ralf Baechle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).