From: Ralf Baechle <ralf@linux-mips.org>
To: Shane McDonald <mcdonald.shane@gmail.com>
Cc: Dmitri Vorobiev <dmitri.vorobiev@movial.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH 2/3] [MIPS] msp71xx: remove unused function
Date: Thu, 15 Oct 2009 01:25:18 +0200 [thread overview]
Message-ID: <20091014232518.GA621@linux-mips.org> (raw)
In-Reply-To: <b2b2f2320910141616p7b53c898gc4bc6a75713d4a8e@mail.gmail.com>
On Wed, Oct 14, 2009 at 05:16:08PM -0600, Shane McDonald wrote:
> > Nobody calls the board-specific prom_getcmdline(), so let's remove it.
> >
> > Build-tested using msp71xx_defconfig.
> >
> > Signed-off-by: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
> >
> >
> NAK. It is called by the MSP71xx's Ethernet driver, whose code has not yet
> made it into the mainline (last submission
> http://www.linux-mips.org/archives/linux-mips/2007-05/msg00210.html).
> Believe it or not, getting that driver whipped into shape is something I'm
> slowly (very slowly) working on.
At a glance, it's not outrageously bad so I suggest you submit it to be
merged into drivers/staging it least it will no longer suffer the bitrot
that out of tree drivers suffer from.
Ralf
next prev parent reply other threads:[~2009-10-14 23:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 19:02 [PATCH 0/3] A few cleanups for MIPS code Dmitri Vorobiev
2009-10-14 19:02 ` [PATCH 1/3] [MIPS] mipssim: remove unused code Dmitri Vorobiev
2009-10-15 9:49 ` Ralf Baechle
2009-12-05 10:41 ` Ralf Baechle
2009-12-05 12:09 ` [PATCH] [MIPS] Fix MIPSsim build after command-line cleanup Dmitri Vorobiev
2009-12-19 22:07 ` Ralf Baechle
2009-12-20 5:03 ` Dmitri Vorobiev
2009-10-14 19:02 ` [PATCH 2/3] [MIPS] msp71xx: remove unused function Dmitri Vorobiev
2009-10-14 23:16 ` Shane McDonald
2009-10-14 23:25 ` Ralf Baechle [this message]
2009-10-15 3:57 ` Shane McDonald
2009-10-14 19:02 ` [PATCH 3/3] [MIPS] remove an unused header file Dmitri Vorobiev
2009-10-14 19:12 ` Manuel Lauss
2009-10-14 19:17 ` Dmitri Vorobiev
2009-10-14 19:37 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091014232518.GA621@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@movial.com \
--cc=linux-mips@linux-mips.org \
--cc=mcdonald.shane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).