From: Ralf Baechle <ralf@linux-mips.org>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Arnaud Patard <apatard@mandriva.com>,
linux-mips@linux-mips.org, LKML <linux-kernel@vger.kernel.org>,
huhb@lemote.com, yanh@lemote.com, Zhang Le <r0bertz@gentoo.org>,
Thomas Gleixner <tglx@linutronix.de>,
Nicholas Mc Guire <der.herr@hofr.at>,
zhangfx@lemote.com, liujl@lemote.com
Subject: Re: [PATCH -queue v0 5/6] [loongson] rtc: enable legacy RTC driver on fuloong2f
Date: Wed, 4 Nov 2009 15:15:45 +0100 [thread overview]
Message-ID: <20091104141545.GA18408@linux-mips.org> (raw)
In-Reply-To: <1257333527.8716.20.camel@falcon.domain.org>
On Wed, Nov 04, 2009 at 07:18:47PM +0800, Wu Zhangjin wrote:
> In reality, fuloong2e, fuloong2f and yeeloong2f work fine with RTC_LIB,
> but relative patches need to append to drivers/rtc/rtc-cmos.c and also
> need a RTC platform device. If what I remembered is right, Gdium also
> need corresponding patches to make it work with RTC_LIB.
>
> Herein, I just let the basic support for those machines work, and then,
> the RTC_LIB support will be sent out later.
>
> and a small question: if legacy RTC driver works well on these machines,
> why should we forbid people to use it? I think it's better to remove the
> "select RTC_LIB" line for MIPS, and then, the people will be free to
> choose what they want, and even for the users whose platform not support
> RTC_LIB.
RTC_LIB is the way to go; the non-RTC_LIB drivers are there only for
backward compatbility. A grep through the defcconfig files for all
platforms on all architectures finds that by now all have set
CONFIG_RTC_LIB and the remaining users of CONFIG_RTC, CONFIG_JS_RTC,
CONFIG_GEN_RTC, CONFIG_EFI_RTC, CONFIG_DS1302 (which all depend on !RTC_LIB)
are all defconfig files which seem to be slowly bitrotting.
Time to axe !RTC_LIB? I'm tempted.
Ralf
next prev parent reply other threads:[~2009-11-04 14:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1257325319.git.wuzhangjin@gmail.com>
2009-11-04 9:04 ` [PATCH -queue v0 1/6] [loongson] add basic loongson-2f support Wu Zhangjin
2009-11-04 10:28 ` Arnaud Patard
2009-11-04 11:04 ` Wu Zhangjin
2009-11-04 11:19 ` Ralf Baechle
2009-11-04 15:23 ` Wu Zhangjin
2009-11-04 20:15 ` Ralf Baechle
2009-11-05 1:39 ` Wu Zhangjin
2009-11-05 8:45 ` Ralf Baechle
2009-11-04 11:36 ` Arnaud Patard
2009-11-05 9:18 ` Ralf Baechle
2009-11-05 9:48 ` Wu Zhangjin
2009-11-05 10:28 ` Ralf Baechle
2009-11-05 11:00 ` Wu Zhangjin
2009-11-04 9:05 ` [PATCH -queue v0 2/6] [loongson] oprofile: avoid do_IRQ for perfcounter when the interrupt is from bonito Wu Zhangjin
2009-11-04 9:05 ` [PATCH -queue v0 3/6] [loongson] add basic cs5536 vsm support Wu Zhangjin
2009-11-04 9:05 ` [PATCH -queue v0 4/6] [loongson] add basic fuloong2f support Wu Zhangjin
2009-11-05 13:16 ` Ralf Baechle
2009-11-05 14:44 ` Wu Zhangjin
2009-11-06 5:39 ` Wu Zhangjin
2009-11-06 8:30 ` Ralf Baechle
2009-11-06 10:05 ` Wu Zhangjin
2009-11-06 8:34 ` Wu Zhangjin
2009-11-04 9:06 ` [PATCH -queue v0 5/6] [loongson] rtc: enable legacy RTC driver on fuloong2f Wu Zhangjin
2009-11-04 10:40 ` Arnaud Patard
2009-11-04 11:18 ` Wu Zhangjin
2009-11-04 11:34 ` Arnaud Patard
2009-11-04 14:15 ` Ralf Baechle [this message]
2009-11-04 15:12 ` Wu Zhangjin
2009-11-04 9:06 ` [PATCH -queue v0 6/6] [loongson] add default config file for fuloong2f Wu Zhangjin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091104141545.GA18408@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=apatard@mandriva.com \
--cc=der.herr@hofr.at \
--cc=huhb@lemote.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=liujl@lemote.com \
--cc=r0bertz@gentoo.org \
--cc=tglx@linutronix.de \
--cc=wuzhangjin@gmail.com \
--cc=yanh@lemote.com \
--cc=zhangfx@lemote.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).