From: Ralf Baechle <ralf@linux-mips.org>
To: Wu Zhangjin <wuzhangjin@gmail.com>
Cc: Paul Gortmaker <p_gortmaker@yahoo.com>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-mips@linux-mips.org, rtc-linux@googlegroups.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 1/3] RTC: rtc-cmos.c: fix warning for MIPS
Date: Thu, 3 Dec 2009 15:56:04 +0000 [thread overview]
Message-ID: <20091203155604.GC28957@linux-mips.org> (raw)
In-Reply-To: <a91e34bf2595157830d599cb66becd52247b1819.1257383766.git.wuzhangjin@gmail.com>
On Thu, Nov 05, 2009 at 09:21:54AM +0800, Wu Zhangjin wrote:
> This patch fixes the following warning with RTC_LIB on MIPS:
>
> drivers/rtc/rtc-cmos.c:697:2: warning: #warning Assuming 128 bytes of
> RTC+NVRAM address space, not 64 bytes.
>
> Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> ---
> drivers/rtc/rtc-cmos.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-cmos.c b/drivers/rtc/rtc-cmos.c
> index f7a4701..21e48f7 100644
> --- a/drivers/rtc/rtc-cmos.c
> +++ b/drivers/rtc/rtc-cmos.c
> @@ -691,7 +691,8 @@ cmos_do_probe(struct device *dev, struct resource *ports, int rtc_irq)
> */
> #if defined(CONFIG_ATARI)
> address_space = 64;
> -#elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) || defined(__sparc__)
> +#elif defined(__i386__) || defined(__x86_64__) || defined(__arm__) \
> + || defined(__sparc__) || defined(__mips__)
> address_space = 128;
> #else
> #warning Assuming 128 bytes of RTC+NVRAM address space, not 64 bytes.
Ping.
This patch is now nearly a month old and I haven't yet heared anything.
This was actually meant to be 2.6.32 material.
Ralf
next prev parent reply other threads:[~2009-12-03 15:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1257383766.git.wuzhangjin@gmail.com>
2009-11-05 1:21 ` [PATCH v1 1/3] RTC: rtc-cmos.c: fix warning for MIPS Wu Zhangjin
2009-11-05 7:41 ` Ralf Baechle
2009-11-10 7:24 ` Wu Zhangjin
2009-12-03 15:56 ` Ralf Baechle [this message]
2009-12-03 16:14 ` [rtc-linux] " Alessandro Zummo
2009-12-03 16:21 ` Wu Zhangjin
2009-11-05 1:22 ` [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f Wu Zhangjin
2009-12-03 16:27 ` [rtc-linux] " Alessandro Zummo
2009-12-03 16:44 ` Wu Zhangjin
2010-01-26 2:03 ` David Brownell
2009-11-05 1:24 ` [PATCH v1 3/3] [loongson] RTC: Registration of Loongson RTC platform device Wu Zhangjin
2009-12-03 16:21 ` [rtc-linux] " Alessandro Zummo
2009-12-03 17:11 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203155604.GC28957@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=linux-mips@linux-mips.org \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).