From: Alessandro Zummo <a.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: wuzhangjin@gmail.com, Paul Gortmaker <p_gortmaker@yahoo.com>,
linux-mips@linux-mips.org
Subject: Re: [rtc-linux] [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f
Date: Thu, 3 Dec 2009 17:27:35 +0100 [thread overview]
Message-ID: <20091203172735.7c934f61@linux.lan.towertech.it> (raw)
In-Reply-To: <f05318584db5160d73af2cfb36b4e3e481a7e7a4.1257383766.git.wuzhangjin@gmail.com>
On Thu, 5 Nov 2009 09:22:09 +0800
Wu Zhangjin <wuzhangjin@gmail.com> wrote:
> */
> - if (is_valid_irq(rtc_irq) &&
> - (!(rtc_control & RTC_24H) || (rtc_control & (RTC_DM_BINARY)))) {
> - dev_dbg(dev, "only 24-hr BCD mode supported\n");
> + if (is_valid_irq(rtc_irq) && !(rtc_control & RTC_24H)) {
> + dev_dbg(dev, "only 24-hr supported\n");
If this check was there it's probably because there are problems
in some other parts of the driver. I'm not keen to add this without
some feedback by the original author or porter.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2009-12-03 16:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1257383766.git.wuzhangjin@gmail.com>
2009-11-05 1:21 ` [PATCH v1 1/3] RTC: rtc-cmos.c: fix warning for MIPS Wu Zhangjin
2009-11-05 7:41 ` Ralf Baechle
2009-11-10 7:24 ` Wu Zhangjin
2009-12-03 15:56 ` Ralf Baechle
2009-12-03 16:14 ` [rtc-linux] " Alessandro Zummo
2009-12-03 16:21 ` Wu Zhangjin
2009-11-05 1:22 ` [PATCH v1 2/3] RTC: rtc-cmos.c: enable RTC_DM_BINARY of RTC_LIB for fuloong2e and fuloong2f Wu Zhangjin
2009-12-03 16:27 ` Alessandro Zummo [this message]
2009-12-03 16:44 ` [rtc-linux] " Wu Zhangjin
2010-01-26 2:03 ` David Brownell
2009-11-05 1:24 ` [PATCH v1 3/3] [loongson] RTC: Registration of Loongson RTC platform device Wu Zhangjin
2009-12-03 16:21 ` [rtc-linux] " Alessandro Zummo
2009-12-03 17:11 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091203172735.7c934f61@linux.lan.towertech.it \
--to=a.zummo@towertech.it \
--cc=linux-mips@linux-mips.org \
--cc=p_gortmaker@yahoo.com \
--cc=rtc-linux@googlegroups.com \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).