* [PATCH 4/8] resources: introduce generic page_is_ram()
[not found] <20100113135305.013124116@intel.com>
@ 2010-01-13 13:53 ` Wu Fengguang
2010-01-13 13:53 ` Wu Fengguang
2010-01-13 14:29 ` Américo Wang
0 siblings, 2 replies; 4+ messages in thread
From: Wu Fengguang @ 2010-01-13 13:53 UTC (permalink / raw)
To: Andrew Morton
Cc: Wu Fengguang, LKML, Chen Liqin, Lennox Wu, Ralf Baechle,
linux-mips, KAMEZAWA Hiroyuki, Andi Kleen, Nick Piggin,
Hugh Dickins, Linux Memory Management List
[-- Attachment #1: page-is-ram.patch --]
[-- Type: text/plain, Size: 2301 bytes --]
It's based on walk_system_ram_range(), for archs that don't have
their own page_is_ram().
The static verions in MIPS and SCORE are also made global.
CC: Chen Liqin <liqin.chen@sunplusct.com>
CC: Lennox Wu <lennox.wu@gmail.com>
CC: Ralf Baechle <ralf@linux-mips.org>
CC: linux-mips@linux-mips.org
CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
arch/mips/mm/init.c | 2 +-
arch/score/mm/init.c | 2 +-
include/linux/ioport.h | 2 ++
kernel/resource.c | 10 ++++++++++
4 files changed, 14 insertions(+), 2 deletions(-)
--- linux-mm.orig/kernel/resource.c 2010-01-10 10:11:53.000000000 +0800
+++ linux-mm/kernel/resource.c 2010-01-10 10:15:33.000000000 +0800
@@ -297,6 +297,16 @@ int walk_system_ram_range(unsigned long
#endif
+static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
+{
+ return 24;
+}
+
+int __attribute__((weak)) page_is_ram(unsigned long pfn)
+{
+ return 24 == walk_system_ram_range(pfn, 1, NULL, __is_ram);
+}
+
/*
* Find empty slot in the resource tree given range and alignment.
*/
--- linux-mm.orig/include/linux/ioport.h 2010-01-10 10:11:53.000000000 +0800
+++ linux-mm/include/linux/ioport.h 2010-01-10 10:11:54.000000000 +0800
@@ -188,5 +188,7 @@ extern int
walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages,
void *arg, int (*func)(unsigned long, unsigned long, void *));
+extern int page_is_ram(unsigned long pfn);
+
#endif /* __ASSEMBLY__ */
#endif /* _LINUX_IOPORT_H */
--- linux-mm.orig/arch/score/mm/init.c 2010-01-10 10:35:38.000000000 +0800
+++ linux-mm/arch/score/mm/init.c 2010-01-10 10:38:04.000000000 +0800
@@ -59,7 +59,7 @@ static unsigned long setup_zero_page(voi
}
#ifndef CONFIG_NEED_MULTIPLE_NODES
-static int __init page_is_ram(unsigned long pagenr)
+int page_is_ram(unsigned long pagenr)
{
if (pagenr >= min_low_pfn && pagenr < max_low_pfn)
return 1;
--- linux-mm.orig/arch/mips/mm/init.c 2010-01-10 10:37:22.000000000 +0800
+++ linux-mm/arch/mips/mm/init.c 2010-01-10 10:37:26.000000000 +0800
@@ -298,7 +298,7 @@ void __init fixrange_init(unsigned long
}
#ifndef CONFIG_NEED_MULTIPLE_NODES
-static int __init page_is_ram(unsigned long pagenr)
+int page_is_ram(unsigned long pagenr)
{
int i;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 4/8] resources: introduce generic page_is_ram()
2010-01-13 13:53 ` [PATCH 4/8] resources: introduce generic page_is_ram() Wu Fengguang
@ 2010-01-13 13:53 ` Wu Fengguang
2010-01-13 14:29 ` Américo Wang
1 sibling, 0 replies; 4+ messages in thread
From: Wu Fengguang @ 2010-01-13 13:53 UTC (permalink / raw)
To: Andrew Morton
Cc: Wu Fengguang, LKML, Chen Liqin, Lennox Wu, Ralf Baechle,
linux-mips, KAMEZAWA Hiroyuki, Andi Kleen, Nick Piggin,
Hugh Dickins, Linux Memory Management List
[-- Attachment #1: page-is-ram.patch --]
[-- Type: text/plain, Size: 2301 bytes --]
It's based on walk_system_ram_range(), for archs that don't have
their own page_is_ram().
The static verions in MIPS and SCORE are also made global.
CC: Chen Liqin <liqin.chen@sunplusct.com>
CC: Lennox Wu <lennox.wu@gmail.com>
CC: Ralf Baechle <ralf@linux-mips.org>
CC: linux-mips@linux-mips.org
CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
arch/mips/mm/init.c | 2 +-
arch/score/mm/init.c | 2 +-
include/linux/ioport.h | 2 ++
kernel/resource.c | 10 ++++++++++
4 files changed, 14 insertions(+), 2 deletions(-)
--- linux-mm.orig/kernel/resource.c 2010-01-10 10:11:53.000000000 +0800
+++ linux-mm/kernel/resource.c 2010-01-10 10:15:33.000000000 +0800
@@ -297,6 +297,16 @@ int walk_system_ram_range(unsigned long
#endif
+static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
+{
+ return 24;
+}
+
+int __attribute__((weak)) page_is_ram(unsigned long pfn)
+{
+ return 24 == walk_system_ram_range(pfn, 1, NULL, __is_ram);
+}
+
/*
* Find empty slot in the resource tree given range and alignment.
*/
--- linux-mm.orig/include/linux/ioport.h 2010-01-10 10:11:53.000000000 +0800
+++ linux-mm/include/linux/ioport.h 2010-01-10 10:11:54.000000000 +0800
@@ -188,5 +188,7 @@ extern int
walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages,
void *arg, int (*func)(unsigned long, unsigned long, void *));
+extern int page_is_ram(unsigned long pfn);
+
#endif /* __ASSEMBLY__ */
#endif /* _LINUX_IOPORT_H */
--- linux-mm.orig/arch/score/mm/init.c 2010-01-10 10:35:38.000000000 +0800
+++ linux-mm/arch/score/mm/init.c 2010-01-10 10:38:04.000000000 +0800
@@ -59,7 +59,7 @@ static unsigned long setup_zero_page(voi
}
#ifndef CONFIG_NEED_MULTIPLE_NODES
-static int __init page_is_ram(unsigned long pagenr)
+int page_is_ram(unsigned long pagenr)
{
if (pagenr >= min_low_pfn && pagenr < max_low_pfn)
return 1;
--- linux-mm.orig/arch/mips/mm/init.c 2010-01-10 10:37:22.000000000 +0800
+++ linux-mm/arch/mips/mm/init.c 2010-01-10 10:37:26.000000000 +0800
@@ -298,7 +298,7 @@ void __init fixrange_init(unsigned long
}
#ifndef CONFIG_NEED_MULTIPLE_NODES
-static int __init page_is_ram(unsigned long pagenr)
+int page_is_ram(unsigned long pagenr)
{
int i;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/8] resources: introduce generic page_is_ram()
2010-01-13 13:53 ` [PATCH 4/8] resources: introduce generic page_is_ram() Wu Fengguang
2010-01-13 13:53 ` Wu Fengguang
@ 2010-01-13 14:29 ` Américo Wang
2010-01-14 3:29 ` Wu Fengguang
1 sibling, 1 reply; 4+ messages in thread
From: Américo Wang @ 2010-01-13 14:29 UTC (permalink / raw)
To: Wu Fengguang
Cc: Andrew Morton, LKML, Chen Liqin, Lennox Wu, Ralf Baechle,
linux-mips, KAMEZAWA Hiroyuki, Andi Kleen, Nick Piggin,
Hugh Dickins, Linux Memory Management List
On Wed, Jan 13, 2010 at 09:53:09PM +0800, Wu Fengguang wrote:
>It's based on walk_system_ram_range(), for archs that don't have
>their own page_is_ram().
>
>The static verions in MIPS and SCORE are also made global.
>
>CC: Chen Liqin <liqin.chen@sunplusct.com>
>CC: Lennox Wu <lennox.wu@gmail.com>
>CC: Ralf Baechle <ralf@linux-mips.org>
>CC: linux-mips@linux-mips.org
>CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
>Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
>---
> arch/mips/mm/init.c | 2 +-
> arch/score/mm/init.c | 2 +-
> include/linux/ioport.h | 2 ++
> kernel/resource.c | 10 ++++++++++
> 4 files changed, 14 insertions(+), 2 deletions(-)
>
>--- linux-mm.orig/kernel/resource.c 2010-01-10 10:11:53.000000000 +0800
>+++ linux-mm/kernel/resource.c 2010-01-10 10:15:33.000000000 +0800
>@@ -297,6 +297,16 @@ int walk_system_ram_range(unsigned long
>
> #endif
>
>+static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
>+{
>+ return 24;
>+}
>+
>+int __attribute__((weak)) page_is_ram(unsigned long pfn)
>+{
>+ return 24 == walk_system_ram_range(pfn, 1, NULL, __is_ram);
>+}
Why do you choose 24 instead of using a macro expressing its meaning?
>+
> /*
> * Find empty slot in the resource tree given range and alignment.
> */
>--- linux-mm.orig/include/linux/ioport.h 2010-01-10 10:11:53.000000000 +0800
>+++ linux-mm/include/linux/ioport.h 2010-01-10 10:11:54.000000000 +0800
>@@ -188,5 +188,7 @@ extern int
> walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages,
> void *arg, int (*func)(unsigned long, unsigned long, void *));
>
>+extern int page_is_ram(unsigned long pfn);
>+
> #endif /* __ASSEMBLY__ */
> #endif /* _LINUX_IOPORT_H */
>--- linux-mm.orig/arch/score/mm/init.c 2010-01-10 10:35:38.000000000 +0800
>+++ linux-mm/arch/score/mm/init.c 2010-01-10 10:38:04.000000000 +0800
>@@ -59,7 +59,7 @@ static unsigned long setup_zero_page(voi
> }
>
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>-static int __init page_is_ram(unsigned long pagenr)
>+int page_is_ram(unsigned long pagenr)
> {
> if (pagenr >= min_low_pfn && pagenr < max_low_pfn)
> return 1;
>--- linux-mm.orig/arch/mips/mm/init.c 2010-01-10 10:37:22.000000000 +0800
>+++ linux-mm/arch/mips/mm/init.c 2010-01-10 10:37:26.000000000 +0800
>@@ -298,7 +298,7 @@ void __init fixrange_init(unsigned long
> }
>
> #ifndef CONFIG_NEED_MULTIPLE_NODES
>-static int __init page_is_ram(unsigned long pagenr)
>+int page_is_ram(unsigned long pagenr)
> {
> int i;
>
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at http://www.tux.org/lkml/
--
Live like a child, think like the god.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 4/8] resources: introduce generic page_is_ram()
2010-01-13 14:29 ` Américo Wang
@ 2010-01-14 3:29 ` Wu Fengguang
0 siblings, 0 replies; 4+ messages in thread
From: Wu Fengguang @ 2010-01-14 3:29 UTC (permalink / raw)
To: Américo Wang
Cc: Andrew Morton, LKML, Chen Liqin, Lennox Wu, Ralf Baechle,
linux-mips@linux-mips.org, KAMEZAWA Hiroyuki, Andi Kleen,
Nick Piggin, Hugh Dickins, Linux Memory Management List
On Wed, Jan 13, 2010 at 10:29:23PM +0800, Américo Wang wrote:
> On Wed, Jan 13, 2010 at 09:53:09PM +0800, Wu Fengguang wrote:
> >It's based on walk_system_ram_range(), for archs that don't have
> >their own page_is_ram().
> >
> >The static verions in MIPS and SCORE are also made global.
> >
> >CC: Chen Liqin <liqin.chen@sunplusct.com>
> >CC: Lennox Wu <lennox.wu@gmail.com>
> >CC: Ralf Baechle <ralf@linux-mips.org>
> >CC: linux-mips@linux-mips.org
> >CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
> >Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> >---
> > arch/mips/mm/init.c | 2 +-
> > arch/score/mm/init.c | 2 +-
> > include/linux/ioport.h | 2 ++
> > kernel/resource.c | 10 ++++++++++
> > 4 files changed, 14 insertions(+), 2 deletions(-)
> >
> >--- linux-mm.orig/kernel/resource.c 2010-01-10 10:11:53.000000000 +0800
> >+++ linux-mm/kernel/resource.c 2010-01-10 10:15:33.000000000 +0800
> >@@ -297,6 +297,16 @@ int walk_system_ram_range(unsigned long
> >
> > #endif
> >
> >+static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
> >+{
> >+ return 24;
> >+}
> >+
> >+int __attribute__((weak)) page_is_ram(unsigned long pfn)
> >+{
> >+ return 24 == walk_system_ram_range(pfn, 1, NULL, __is_ram);
> >+}
>
>
> Why do you choose 24 instead of using a macro expressing its meaning?
Hmm, I thought they are close enough to be obvious.
Anyway this should look better:
resources: introduce generic page_is_ram()
It's based on walk_system_ram_range(), for archs that don't have
their own page_is_ram().
The static verions in MIPS and SCORE are also made global.
CC: Chen Liqin <liqin.chen@sunplusct.com>
CC: Lennox Wu <lennox.wu@gmail.com>
CC: Ralf Baechle <ralf@linux-mips.org>
CC: Américo Wang <xiyou.wangcong@gmail.com>
CC: linux-mips@linux-mips.org
CC: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
---
arch/mips/mm/init.c | 2 +-
arch/score/mm/init.c | 2 +-
include/linux/ioport.h | 2 ++
kernel/resource.c | 11 +++++++++++
4 files changed, 15 insertions(+), 2 deletions(-)
--- linux-mm.orig/kernel/resource.c 2010-01-13 21:27:28.000000000 +0800
+++ linux-mm/kernel/resource.c 2010-01-14 11:28:20.000000000 +0800
@@ -297,6 +297,17 @@ int walk_system_ram_range(unsigned long
#endif
+#define PAGE_IS_RAM 24
+static int __is_ram(unsigned long pfn, unsigned long nr_pages, void *arg)
+{
+ return PAGE_IS_RAM;
+}
+int __attribute__((weak)) page_is_ram(unsigned long pfn)
+{
+ return PAGE_IS_RAM == walk_system_ram_range(pfn, 1, NULL, __is_ram);
+}
+#undef PAGE_IS_RAM
+
/*
* Find empty slot in the resource tree given range and alignment.
*/
--- linux-mm.orig/include/linux/ioport.h 2010-01-13 21:27:28.000000000 +0800
+++ linux-mm/include/linux/ioport.h 2010-01-13 21:44:50.000000000 +0800
@@ -188,5 +188,7 @@ extern int
walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages,
void *arg, int (*func)(unsigned long, unsigned long, void *));
+extern int page_is_ram(unsigned long pfn);
+
#endif /* __ASSEMBLY__ */
#endif /* _LINUX_IOPORT_H */
--- linux-mm.orig/arch/score/mm/init.c 2010-01-13 21:27:28.000000000 +0800
+++ linux-mm/arch/score/mm/init.c 2010-01-13 21:44:50.000000000 +0800
@@ -59,7 +59,7 @@ static unsigned long setup_zero_page(voi
}
#ifndef CONFIG_NEED_MULTIPLE_NODES
-static int __init page_is_ram(unsigned long pagenr)
+int page_is_ram(unsigned long pagenr)
{
if (pagenr >= min_low_pfn && pagenr < max_low_pfn)
return 1;
--- linux-mm.orig/arch/mips/mm/init.c 2010-01-13 21:27:28.000000000 +0800
+++ linux-mm/arch/mips/mm/init.c 2010-01-13 21:44:50.000000000 +0800
@@ -298,7 +298,7 @@ void __init fixrange_init(unsigned long
}
#ifndef CONFIG_NEED_MULTIPLE_NODES
-static int __init page_is_ram(unsigned long pagenr)
+int page_is_ram(unsigned long pagenr)
{
int i;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-14 3:29 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20100113135305.013124116@intel.com>
2010-01-13 13:53 ` [PATCH 4/8] resources: introduce generic page_is_ram() Wu Fengguang
2010-01-13 13:53 ` Wu Fengguang
2010-01-13 14:29 ` Américo Wang
2010-01-14 3:29 ` Wu Fengguang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).