From: Ralf Baechle <ralf@linux-mips.org>
To: David Daney <ddaney@caviumnetworks.com>
Cc: Roel Kluin <roel.kluin@gmail.com>,
linux-mips@linux-mips.org,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] MIPS: cleanup switches with cases that can be merged
Date: Sat, 23 Jan 2010 17:31:58 +0100 [thread overview]
Message-ID: <20100123163158.GB5570@linux-mips.org> (raw)
In-Reply-To: <4B56641E.1030803@caviumnetworks.com>
On Tue, Jan 19, 2010 at 06:02:06PM -0800, David Daney wrote:
> This patch should be split up.
>
> Octeon, PowerTV, and IP32 are all different architectures. They
> should be in their own patches.
>
> The two math-emu parts could probably go together.
>
> cpu-probe seems like its own thing.
It's conceptually the same change that's being applied everywhere and the
total size is modest so I'm happy to apply it as just a single patch as is.
> This brings us to the larger question: This is just code churn. Is
> it even worthwhile?
This has been discussed many times over and we maintainers have not come to
a final conclusion on this type of patches. I tend to apply this sort of
patches anyway but treat them as low priority.
Ralf
next prev parent reply other threads:[~2010-01-23 16:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-19 23:59 [PATCH] MIPS: cleanup switches with cases that can be merged Roel Kluin
2010-01-20 2:02 ` David Daney
2010-01-20 11:47 ` Alexander Clouter
2010-01-23 16:31 ` Ralf Baechle [this message]
2010-01-24 0:23 ` Ralf Baechle
2010-01-24 17:58 ` 1 GB RAM with RM9000 SOC Anoop P.A.
2010-01-24 17:58 ` Anoop P.A.
2010-01-25 17:15 ` David Daney
2010-01-25 17:34 ` Anoop P.A.
2010-01-25 17:34 ` Anoop P.A.
2010-01-25 17:38 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100123163158.GB5570@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).