From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: Ralf Baechle <ralf@linux-mips.org>, linux-mips@linux-mips.org
Subject: Re: RFC: [MIPS] BCM1480HT set mips_io_port_base
Date: Wed, 24 Feb 2010 23:00:49 +0100 [thread overview]
Message-ID: <20100224220049.GA20280@alpha.franken.de> (raw)
In-Reply-To: <201002241347.07685.bjorn.helgaas@hp.com>
On Wed, Feb 24, 2010 at 01:47:07PM -0700, Bjorn Helgaas wrote:
> I don't see anywhere that BCM1480HT sets mips_io_port_base (but maybe
> I missed it). We *do* set bcm1480ht_controller.io_map_base, so pci_iomap()
> should work, but without mips_io_port_base, I don't think inb() et al.
> will work.
there are two hoses on the BCM1480 one is a via the PCI host controller
the other one via the hypertransport. set_io_port_base() is an old hack
to get inX/outX drivers working. Drivers using in/out will only work for
devices on the PCI host controller and will be broken for devies on the
HT side. Your change will make the devices on the HT side working, but
break the one on the PCI bus. Either way isn't too nice, but at least
nobody had a problem with the current behaviour. So it might be better
to not apply your patch.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessary a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2010-02-24 22:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-24 20:47 RFC: [MIPS] BCM1480HT set mips_io_port_base Bjorn Helgaas
2010-02-24 22:00 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100224220049.GA20280@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=bjorn.helgaas@hp.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox