From: Ralf Baechle <ralf@linux-mips.org>
To: Yang Shi <yang.shi@windriver.com>
Cc: ddaney@caviumnetworks.com, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c
Date: Tue, 9 Mar 2010 20:03:09 +0100 [thread overview]
Message-ID: <20100309190309.GA301@linux-mips.org> (raw)
In-Reply-To: <1268115862-25976-1-git-send-email-yang.shi@windriver.com>
On Tue, Mar 09, 2010 at 02:24:22PM +0800, Yang Shi wrote:
> Change cvmx_ciu_wdogx_t type to "union cvmx_ciu_wdogx".
>
> Signed-off-by: Yang Shi <yang.shi@windriver.com>
> ---
> arch/mips/cavium-octeon/smp.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
> index 51e9802..52d61ba 100644
> --- a/arch/mips/cavium-octeon/smp.c
> +++ b/arch/mips/cavium-octeon/smp.c
> @@ -281,7 +281,7 @@ static void octeon_cpu_die(unsigned int cpu)
>
> #ifdef CONFIG_CAVIUM_OCTEON_WATCHDOG
> /* Disable the watchdog */
> - cvmx_ciu_wdogx_t ciu_wdog;
> + union cvmx_ciu_wdogx ciu_wdog;
> ciu_wdog.u64 = cvmx_read_csr(CVMX_CIU_WDOGX(cpu));
> ciu_wdog.s.mode = 0;
> cvmx_write_csr(CVMX_CIU_WDOGX(cpu), ciu_wdog.u64);
David,
I think this ifdef should be replaced by a notifier called from
__cpu_die().
Ralf
next prev parent reply other threads:[~2010-03-09 19:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 6:24 [PATCH] MIPS: Octeon: Fix wrong variable type in smp.c Yang Shi
2010-03-09 19:03 ` Ralf Baechle [this message]
2010-03-09 19:17 ` Ralf Baechle
2010-03-11 2:53 ` Yang Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100309190309.GA301@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=yang.shi@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox