From: Ralf Baechle <ralf@linux-mips.org>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
Linux-MIPS <linux-mips@linux-mips.org>,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH] MIPS: Alchemy: move MMC driver registration to board code.
Date: Wed, 10 Mar 2010 17:48:24 +0100 [thread overview]
Message-ID: <20100310164824.GC15118@linux-mips.org> (raw)
In-Reply-To: <f861ec6f1003090403j190d0ddbp7e245d0990a62a51@mail.gmail.com>
On Tue, Mar 09, 2010 at 01:03:51PM +0100, Manuel Lauss wrote:
> And on a personal note, that file just bothers me. It's messy, can
> cause merge conflicts,
Eye cancer.
> it references structures defined inside board-specific code. In short,
> it just plain annoys
> my sense of aesthetics.
Indeed - and I don't think Sergej disagrees with that. I agree with him
that device registration code should primarily be done in the SOC code -
but you'll need to somehow get that code to communicate with the platform
code about what really needs to be done then register the remainder of
the truely platform-specific platform devices. Something like that.
Ralf
next prev parent reply other threads:[~2010-03-10 16:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-08 19:22 [PATCH] MIPS: Alchemy: sleepcode without compile-time cputype dependencies Manuel Lauss
2010-03-08 19:23 ` [RFC PATCH] MIPS: Alchemy: add sysdev for both irq controllers Manuel Lauss
2010-03-10 16:13 ` Ralf Baechle
2010-03-10 19:03 ` Manuel Lauss
2010-03-08 19:23 ` [PATCH] MIPS: Alchemy: move MMC driver registration to board code Manuel Lauss
2010-03-09 11:33 ` Sergei Shtylyov
2010-03-09 11:45 ` Manuel Lauss
2010-03-09 11:45 ` Manuel Lauss
2010-03-09 11:51 ` Sergei Shtylyov
2010-03-09 12:03 ` Manuel Lauss
2010-03-09 12:03 ` Manuel Lauss
2010-03-10 16:48 ` Ralf Baechle [this message]
2010-03-10 18:34 ` Manuel Lauss
2010-03-10 18:34 ` Manuel Lauss
2010-03-10 16:04 ` [PATCH] MIPS: Alchemy: sleepcode without compile-time cputype dependencies Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100310164824.GC15118@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).