From: Ralf Baechle <ralf@linux-mips.org>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Manuel Lauss <manuel.lauss@gmail.com>
Subject: Re: [PATCH] MIPS: Alchemy: db1200: remove custom wait implementation
Date: Wed, 7 Apr 2010 16:34:56 +0100 [thread overview]
Message-ID: <20100407153454.GA24682@linux-mips.org> (raw)
In-Reply-To: <1270307223-3825-1-git-send-email-manuel.lauss@gmail.com>
On Sat, Apr 03, 2010 at 05:07:03PM +0200, Manuel Lauss wrote:
> While playing with the out-of-tree MAE driver module, the system
> would panic after a while in the db1200 custom wait code after
> wakeup due to a clobbered k0 register being used as target address
> of a store op.
>
> Remove the custom wait implementation and revert back to the
> Alchemy-recommended implementation already set as default.
>
> Signed-off-by: Manuel Lauss <manuel.lauss@gmail.com>
> ---
> I've played a few hours worth of video from a SD card now without
> a hitch; usually the panic would occur after ~10 minutes.
>
> Please add this to the 2.6.34 queue, Thanks!
Yes, this use of k0 was definately looking fishy - and I'm not talking
about the kind of fish in a bouillabaisse ;-)
Applied. Thanks!
Ralf
prev parent reply other threads:[~2010-04-07 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-03 15:07 [PATCH] MIPS: Alchemy: db1200: remove custom wait implementation Manuel Lauss
2010-04-07 15:34 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100407153454.GA24682@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox