From: Ralf Baechle <ralf@linux-mips.org>
To: Yury Polyanskiy <ypolyans@princeton.edu>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] die() does not call die notifier chain
Date: Wed, 28 Apr 2010 19:31:43 +0100 [thread overview]
Message-ID: <20100428183143.GA5623@linux-mips.org> (raw)
In-Reply-To: <20100426005310.0786273f@penta.localdomain>
On Mon, Apr 26, 2010 at 12:53:10AM -0400, Yury Polyanskiy wrote:
Yuri,
> I think that the arch/mips implementation of die() forgets to call the
> notify_die() and thus notifiers registered via register_die_notifier()
> are not called.
>
> For example this results in kgdb not being activated on exceptions.
>
> The patch is very simple and attached: the only subtlety is that main
> notify_die declares regs argument w/o const, so I needed to remove const
> from mips die() as well.
I'd have prefered to make all users of the reg pointer const in the hope
gcc can use that for optimization and to avoid stupid assignments via that
pointer but that turns out a significant problem on its own so I'm applying
your patch as is.
Please include a Signed-off-by: line (see Documentation/SubmittingPatches)
in future patches. If your patch was any more complex than this I'd not
have considered it without one.
Thanks!
Ralf
prev parent reply other threads:[~2010-04-28 18:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-26 4:53 [PATCH] die() does not call die notifier chain Yury Polyanskiy
2010-04-28 18:31 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428183143.GA5623@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=ypolyans@princeton.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox