From: Ralf Baechle <ralf@linux-mips.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: wuzhangjin@gmail.com, linux-mips <linux-mips@linux-mips.org>
Subject: Re: About MIPS specific dma_mmap_coherent()
Date: Tue, 11 May 2010 19:48:44 +0100 [thread overview]
Message-ID: <20100511184844.GA7978@linux-mips.org> (raw)
In-Reply-To: <s5h633uxcje.wl%tiwai@suse.de>
On Wed, Apr 14, 2010 at 05:46:13PM +0200, Takashi Iwai wrote:
> But, I remember vaguely that calling pgprot_noncached()
> unconditionally is dangerous. It should be checked somehow, e.g. via
> platform_device_is_coherent(). And, this found only in
> dma-coherence.h, and adding it to pcm_native.c would become messy like
> below...
>
> So, it'd be really better to add dma_mmap_coherent(), indeed.
We agreed that this was only meant as a stop gap meassure. As such I do
agree with either of
http://patchwork.linux-mips.org/patch/1117/
http://patchwork.linux-mips.org/patch/1118/
Wu has tested the 1117 patch so that might make it preferable especially
for 2.6.34 if we should go for that.
Ralf
next prev parent reply other threads:[~2010-05-11 18:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-13 4:58 About MIPS specific dma_mmap_coherent() Wu Zhangjin
2010-04-13 16:49 ` Takashi Iwai
2010-04-14 4:21 ` Wu Zhangjin
2010-04-14 6:31 ` Takashi Iwai
2010-04-14 9:00 ` Wu Zhangjin
2010-04-14 15:46 ` Takashi Iwai
2010-05-11 18:48 ` Ralf Baechle [this message]
2010-05-12 6:42 ` Wu Zhangjin
2010-05-12 8:41 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100511184844.GA7978@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=tiwai@suse.de \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox