From: Ralf Baechle <ralf@linux-mips.org>
To: Julia Lawall <julia@diku.dk>, "Kevin D. Kissell" <kevink@paralogos.com>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 3/17] arch/mips/kernel: Add missing read_unlock
Date: Wed, 26 May 2010 17:32:27 +0100 [thread overview]
Message-ID: <20100526163227.GA17043@linux-mips.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1005261754390.23743@ask.diku.dk>
On Wed, May 26, 2010 at 05:54:55PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Add a read_unlock missing on the error path. Other ways of reaching
> out_unlock have tasklist_lock unlocked.
>
> The semantic match that finds this problem is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression E1;
> @@
>
> * read_lock(E1,...);
> <+... when != E1
> if (...) {
> ... when != E1
> * return ...;
> }
> ...+>
> * read_unlock(E1,...);
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
> I wasn't able to find what security_task_setscheduler actually does.
> If it releases tasklist_lock in an error case, then ignire this patch.
Your patch appears correct - and mipsmt_sys_sched_setaffinity() even
more broken than you thought. It duplicates some code from kernel/sched.c
and has gotten out of sync.
Fixing that up.
Ralf
next prev parent reply other threads:[~2010-05-26 16:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 15:54 [PATCH 3/17] arch/mips/kernel: Add missing read_unlock Julia Lawall
2010-05-26 16:32 ` Ralf Baechle [this message]
2010-05-26 17:27 ` Affinity Automation (was Re: [PATCH 3/17] arch/mips/kernel: Add missing read_unlock) Kevin D. Kissell
2010-05-26 17:38 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100526163227.GA17043@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=kevink@paralogos.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox