From: Sam Ravnborg <sam@ravnborg.org>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH -queue v2] MIPS: Move Alchemy Makefile parts to their own Platform file.
Date: Tue, 1 Jun 2010 18:35:28 +0200 [thread overview]
Message-ID: <20100601163528.GA5216@merkur.ravnborg.org> (raw)
In-Reply-To: <1275405795-9009-1-git-send-email-manuel.lauss@googlemail.com>
On Tue, Jun 01, 2010 at 05:23:15PM +0200, Manuel Lauss wrote:
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> ---
> On top of latest mips-queue. The changes to the mtx1/xx1500 Makefiles were
> necessary to work around vmlinux link failures.
Was this something the platform patches introduced or
is it needed to fix the build?
In the first case I have broken something I need to fix.
In the latter case this should be a seperate patch (that comes first).
> diff --git a/arch/mips/alchemy/Platform b/arch/mips/alchemy/Platform
> new file mode 100644
> index 0000000..495cc9a
> --- /dev/null
> +++ b/arch/mips/alchemy/Platform
...
> +#
> +# 4G-Systems eval board
> +#
> +platform-$(CONFIG_MIPS_MTX1) += alchemy/mtx-1/
> +load-$(CONFIG_MIPS_MTX1) += 0xffffffff80100000
> diff --git a/arch/mips/alchemy/mtx-1/Makefile b/arch/mips/alchemy/mtx-1/Makefile
> index 4a53815..4d1367e 100644
> --- a/arch/mips/alchemy/mtx-1/Makefile
> +++ b/arch/mips/alchemy/mtx-1/Makefile
> @@ -6,7 +6,6 @@
> # Makefile for 4G Systems MTX-1 board.
> #
>
> -lib-y := init.o board_setup.o
> -obj-y := platform.o
> +obj-y := init.o board_setup.o platform.o
>
> EXTRA_CFLAGS += -Werror
In the above we added alchemy/mtx-1/ to platform-y
so mtx-1/ is automatically covered by -Werror by arch/mips/Kbuild
So the above assignment to EXTRA_CFLAGS is now redundant and can be dropped.
Sam
next prev parent reply other threads:[~2010-06-01 16:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-01 15:23 [PATCH -queue v2] MIPS: Move Alchemy Makefile parts to their own Platform file Manuel Lauss
2010-06-01 16:35 ` Sam Ravnborg [this message]
2010-06-01 16:47 ` Manuel Lauss
2010-06-01 16:47 ` Manuel Lauss
2010-06-01 20:02 ` Sam Ravnborg
2010-06-01 20:12 ` Manuel Lauss
2010-06-01 20:12 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100601163528.GA5216@merkur.ravnborg.org \
--to=sam@ravnborg.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox