From: Alexander Clouter <alex@digriz.org.uk>
To: wuzhangjin@gmail.com
Cc: Ralf Baechle <ralf@linux-mips.org>,
linux-mips <linux-mips@linux-mips.org>,
Manuel Lauss <manuel.lauss@gmail.com>,
sam@ravnborg.org
Subject: Re: [PATCH v4] MIPS: Clean up the calculation of VMLINUZ_LOAD_ADDRESS
Date: Wed, 2 Jun 2010 22:50:56 +0100 [thread overview]
Message-ID: <20100602215056.GX2519@chipmunk> (raw)
In-Reply-To: <20100602194817.GA7530@merkur.ravnborg.org>
* Sam Ravnborg <sam@ravnborg.org> [2010-06-02 21:48:17+0200]:
>
> On Wed, Jun 02, 2010 at 04:35:25PM +0800, Wu Zhangjin wrote:
> > We have calculated VMLINUZ_LOAD_ADDRESS in shell, which is indecipherable. This
> > patch rewrites it in C.
> >
> > Changes:
> >
> > v3 -> v4: (feedback from Sam Ravnborg)
> > o Makefile: Follow the 80 characters' limit and Remove an un-needed objcopy.
> > o calc_vmlinuz_load_addr.c: Use a smaller alignment and Add more comments
> >
> > v2 -> v3: (feedback from Alexander Clouter)
> > o Drop the unneeded variable n
> > o Replace the last "unsigned long long" by uint64_t
> >
> > v1 -> v2: (feedback from Alexander Clouter)
> > o make it more portable
> > use EXIT_SUCCESS and EXIT_FAILURE as the return value, and use uint64_t
> > instead of "unsigned long long".
> > o add a missing return value
> > return EXIT_FAILURE if sscanf() not return 1
> >
> > Signed-off-by: Wu Zhangjin <wuzhangjin@gmail.com>
> Acked-by: Sam Ravnborg <sam@ravnborg.org>
Reviewed-by: Alexander Clouter <alex@digriz.org.uk>
--
Alexander Clouter
.sigmonster says: The price of greatness is responsibility.
next prev parent reply other threads:[~2010-06-02 21:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-02 8:35 [PATCH v2] MIPS: Unify the suffix of compressed vmlinux.bin Wu Zhangjin
2010-06-02 8:35 ` [PATCH v4] MIPS: Clean up the calculation of VMLINUZ_LOAD_ADDRESS Wu Zhangjin
2010-06-02 19:48 ` Sam Ravnborg
2010-06-02 21:50 ` Alexander Clouter [this message]
2010-08-05 1:32 ` Ralf Baechle
2010-08-05 4:50 ` wu zhangjin
2010-07-29 1:32 ` [PATCH v2] MIPS: Unify the suffix of compressed vmlinux.bin wu zhangjin
2010-08-05 3:10 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100602215056.GX2519@chipmunk \
--to=alex@digriz.org.uk \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@gmail.com \
--cc=ralf@linux-mips.org \
--cc=sam@ravnborg.org \
--cc=wuzhangjin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).