Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: naveen yadav <yad.naveen@gmail.com>
Cc: linux-mips@linux-mips.org
Subject: Re: kmalloc issue on MIPS target
Date: Wed, 18 Aug 2010 15:43:01 +0100	[thread overview]
Message-ID: <20100818144301.GC2849@linux-mips.org> (raw)
In-Reply-To: <AANLkTin8LLH3DkX38B93Ap0mmz4hb9e=cEo9U3ZKmavr@mail.gmail.com>

On Wed, Aug 18, 2010 at 07:56:16PM +0530, naveen yadav wrote:

> I will give more info.
> 
> CONFIG_MIPS_L1_CACHE_SHIFT=5
> 
> CONFIG_DMA_NONCOHERENT=y
> 
> mips 34kc is processor
> 
> and File we are using is  arch/mips/include/asm/mach-generic/kmalloc.h
> 
> #ifndef __ASM_MACH_GENERIC_KMALLOC_H
> #define __ASM_MACH_GENERIC_KMALLOC_H
> 
> 
> #ifndef CONFIG_DMA_COHERENT
> /*
>  * Total overkill for most systems but need as a safe default.
>  * Set this one if any device in the system might do non-coherent DMA.
>  */
> #define ARCH_KMALLOC_MINALIGN   128
> #endif
> 
> #endif /* __ASM_MACH_GENERIC_KMALLOC_H */
> 
> 
> So shall we make value ARCH_KMALLOC_MINALIGN   from 128 to 32. is
> there any problem ?

No, that's just what you should do.  You do that by putting a file
that defines ARCH_KMALLOC_MINALIGN into your platforms's
arch/mips/include/asm/mach-<yourplatform>/kmalloc.h just like the ip32
file from your original posting.

  Ralf

  reply	other threads:[~2010-08-18 14:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-18 12:37 kmalloc issue on MIPS target naveen yadav
2010-08-18 12:44 ` naveen yadav
2010-08-18 13:33 ` Ralf Baechle
2010-08-18 14:26   ` naveen yadav
2010-08-18 14:43     ` Ralf Baechle [this message]
2010-08-18 15:22       ` naveen yadav
2010-08-18 16:09         ` Sergei Shtylyov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100818144301.GC2849@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-mips@linux-mips.org \
    --cc=yad.naveen@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox