From: Ralf Baechle <ralf@linux-mips.org>
To: Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org, linux-mips@linux-mips.org
Subject: Re: [PATCH 01/25] arch/mips: Use static const char arrays
Date: Sat, 18 Sep 2010 23:54:47 +0100 [thread overview]
Message-ID: <20100918225447.GA4739@linux-mips.org> (raw)
In-Reply-To: <8fcec0d2a48e806558e6bc39d5aa98518a97f8c7.1284406638.git.joe@perches.com>
On Mon, Sep 13, 2010 at 12:47:39PM -0700, Joe Perches wrote:
> diff --git a/arch/mips/pnx8550/common/reset.c b/arch/mips/pnx8550/common/reset.c
> index fadd874..e0ac0b2 100644
> --- a/arch/mips/pnx8550/common/reset.c
> +++ b/arch/mips/pnx8550/common/reset.c
> @@ -27,8 +27,8 @@
>
> void pnx8550_machine_restart(char *command)
> {
> - char head[] = "************* Machine restart *************";
> - char foot[] = "*******************************************";
> + static const char head[] = "************* Machine restart *************";
> + static const char foot[] = "*******************************************";
>
> printk("\n\n");
> printk("%s\n", head);
NAK.
The printks should have been taken out and shot. And while at it line
use the space on the other side of the wall for pnx8550_machine_power_off.
Ralf
next prev parent reply other threads:[~2010-09-18 22:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-13 19:47 [PATCH 00/25] treewide-next: Use static const char arrays Joe Perches
2010-09-13 19:47 ` [PATCH 01/25] arch/mips: " Joe Perches
2010-09-18 22:54 ` Ralf Baechle [this message]
2010-09-18 23:44 ` Joe Perches
2010-09-14 9:14 ` (no subject) David Howells
2010-09-14 9:14 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100918225447.GA4739@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox