From: Ralf Baechle <ralf@linux-mips.org>
To: Dmitri Vorobiev <dmitri.vorobiev@movial.com>
Cc: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Fix build failure for IP22
Date: Thu, 9 Dec 2010 18:46:38 +0000 [thread overview]
Message-ID: <20101209184638.GD30923@linux-mips.org> (raw)
In-Reply-To: <1290511948-10347-1-git-send-email-dmitri.vorobiev@movial.com>
On Tue, Nov 23, 2010 at 01:32:28PM +0200, Dmitri Vorobiev wrote:
> Commit 48e1fd5a81416a037f5a48120bf281102f2584e2 changed the name
> of the MIPS-specific dma_cache_sync() routine by prefixing it with
> `mips_', and removed the export for its symbol. Two drivers, which
> did use dma_cache_sync(), namely, sgiseeq and sgiwd93, were not
> converted to use the new function, which led to build failure for
> the IP22 platform.
>
> This patch fixes the build failure by fixing the call sites of
> mips_dma_cache_sync() and exporting the symbol for this routine as
> a GPL symbol. While at it, some minor changes to improve Kconfig
> help entries were done.
dma_cache_sync isn't MIPS specific - mips_dma_cache_sync is but the
function wasn't renamed everywhere. Looking into what went wrong now
but your patch surely is not correct.
Ralf
next prev parent reply other threads:[~2010-12-09 18:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 11:32 [PATCH] MIPS: Fix build failure for IP22 Dmitri Vorobiev
2010-11-23 12:05 ` Sergei Shtylyov
2010-11-23 17:11 ` Thomas Bogendoerfer
2010-12-09 18:46 ` Ralf Baechle [this message]
2010-12-09 20:34 ` Dmitri Vorobiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101209184638.GD30923@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dmitri.vorobiev@movial.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox