From: Ralf Baechle <ralf@linux-mips.org>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH V2] MIPS: Alchemy: fix build with SERIAL_8250=n
Date: Fri, 10 Dec 2010 20:40:52 +0000 [thread overview]
Message-ID: <20101210204052.GA1274@linux-mips.org> (raw)
In-Reply-To: <1288025051-17145-1-git-send-email-manuel.lauss@googlemail.com>
On Mon, Oct 25, 2010 at 06:44:11PM +0200, Manuel Lauss wrote:
> In commit 7d172bfe ("Alchemy: Add UART PM methods") I introduced
> platform PM methods which call a function of the 8250 driver;
> this patch works around link failures when the kernel is built
> without 8250 support.
>
> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> ---
> V2: added commit name to patch description as per Sergei's suggestion.
Applied, thanks.
Though anything like a CONFIG_SERIAL_8250 in board code always strikes me
as wrong. What if the driver is built as a module? What if the kernel is
built without the driver, then later on the module is built separately and
then inserted?
Ralf
next prev parent reply other threads:[~2010-12-10 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-25 16:44 [PATCH V2] MIPS: Alchemy: fix build with SERIAL_8250=n Manuel Lauss
2010-12-10 20:40 ` Ralf Baechle [this message]
2010-12-10 20:56 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101210204052.GA1274@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox