From: Ralf Baechle <ralf@linux-mips.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: David Daney <ddaney@caviumnetworks.com>, linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: Use WARN() in uasm for better diagnostics.
Date: Tue, 28 Dec 2010 16:54:11 +0100 [thread overview]
Message-ID: <20101228155411.GB31111@linux-mips.org> (raw)
In-Reply-To: <4D1A05D9.9050707@mvista.com>
On Tue, Dec 28, 2010 at 06:44:25PM +0300, Sergei Shtylyov wrote:
> > static inline __uasminit u32 build_jimm(u32 arg)
> > {
> >- if (arg & ~((JIMM_MASK) << 2))
> >- printk(KERN_WARNING "Micro-assembler field overflow\n");
> >+ WARN(arg & ~((JIMM_MASK) << 2),
>
> Could drop parens around JIMM_MASK while at it...
Done.
Ralf
prev parent reply other threads:[~2010-12-28 15:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-28 2:18 [PATCH] MIPS: Use WARN() in uasm for better diagnostics David Daney
2010-12-28 15:31 ` Ralf Baechle
2010-12-28 15:44 ` Sergei Shtylyov
2010-12-28 15:54 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101228155411.GB31111@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox