Linux MIPS Architecture development
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: linux-mips@linux-mips.org, ralf@linux-mips.org
Subject: Re: [PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support
Date: Wed, 19 Jan 2011 15:30:49 +0100	[thread overview]
Message-ID: <20110119143049.GA4820@lst.de> (raw)
In-Reply-To: <1295349645-16805-1-git-send-email-aurelien@aurel32.net>

On Tue, Jan 18, 2011 at 12:20:44PM +0100, Aurelien Jarno wrote:
> Add CONFIG_VIRTUALIZATION to the MIPS architecture and include the
> the virtio code there. Used to enable the virtio drivers under QEMU.
> 
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
>  arch/mips/Kconfig |   16 ++++++++++++++++

> +menuconfig VIRTUALIZATION
> +	bool "Virtualization"
> +	default n
> +	---help---
> +	  Say Y here to get to see options for using your Linux host to run other
> +	  operating systems inside virtual machines (guests).
> +	  This option alone does not add any kernel code.
> +
> +	  If you say N, all options in this submenu will be skipped and disabled.

This item seems rather misleading as you're using virtio drivers as a
guest.  I think the right fix is to just remove the VIRTUALIZATION
dependency for the qemu drivers and just include them from
drivers/Kconfig for all architectures.  There aren't a whole lot Linux
architectures that don't have a qemu emulation these days.

  parent reply	other threads:[~2011-01-19 14:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-18 11:20 [PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support Aurelien Jarno
2011-01-18 11:20 ` [PATCH 2/2] MIPS: Malta: enable Cirrus FB console Aurelien Jarno
2011-01-18 18:14   ` Ralf Baechle
2011-01-18 18:13 ` [PATCH 1/2] MIPS: add CONFIG_VIRTUALIZATION for virtio support Ralf Baechle
2011-01-19 14:30 ` Christoph Hellwig [this message]
2011-01-22 14:31   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110119143049.GA4820@lst.de \
    --to=hch@lst.de \
    --cc=aurelien@aurel32.net \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox