From: Ralf Baechle <ralf@linux-mips.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-mips@linux-mips.org
Subject: Re: mips allmodconfig
Date: Sun, 30 Jan 2011 17:04:44 +0100 [thread overview]
Message-ID: <20110130160444.GA2876@linux-mips.org> (raw)
In-Reply-To: <s5hfwsdcwht.wl%tiwai@suse.de>
On Fri, Jan 28, 2011 at 08:34:22AM +0100, Takashi Iwai wrote:
> > sound/oss/soundcard.c:69: error: `MAX_DMA_CHANNELS' undeclared here (not in a function)
> > sound/oss/soundcard.c:69: error: storage size of `dma_alloc_map' isn't known
> > sound/oss/soundcard.c:69: warning: 'dma_alloc_map' defined but not used
> >
> > In case you happen to be interested in oss drivers ;)
>
> I took a quick look. The only case where no MAX_DMA_CHANNELS is
> defined is only MIPS with CONFIG_GENERIC_ISA_DMA_SUPPORT_BROKEN.
> In arch/mips/include/asm/dma.h:
>
> #ifndef CONFIG_GENERIC_ISA_DMA_SUPPORT_BROKEN
> #define MAX_DMA_CHANNELS 8
> #endif
>
> What is the intention of this ifdef?
Uh... It's a while, took a little headscratching until I remembered
again and I think the comment of aa414dff4f7bef29457592414551becdca72dd6b
is bogus ...
CONFIG_GENERIC_ISA_DMA enabled but MAX_DMA_CHANNELS disabled selects a
dummy version of the ISA DMA controller API. Some drivers don't have
correct dependencies or ifdefs on CONFIG_GENERIC_ISA_DMA or don't
have correct fallback strategies in case of CONFIG_GENERIC_ISA_DMA=n.
In those cases just leaving MAX_DMA_CHANNELS undefined is useful. This
is used on SGI Indigo² systems which have EISA slots but ISA DMA isn't
supported yet by Linux.
> Takashi (not interested but just bored ;)
Very interested boredom ;-)
Ralf
prev parent reply other threads:[~2011-01-30 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110125143113.55aea198.akpm@linux-foundation.org>
2011-01-28 7:34 ` mips allmodconfig Takashi Iwai
2011-01-30 16:04 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110130160444.GA2876@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=akpm@linux-foundation.org \
--cc=linux-mips@linux-mips.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox