From: Ralf Baechle <ralf@linux-mips.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Nikolay Ledovskikh <nledovskikh@gmail.com>,
"John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, lrodriguez@atheros.com,
mickflemm@gmail.com, me@bobcopeland.com,
linux-mips@linux-mips.org
Subject: Re: [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips
Date: Wed, 16 Feb 2011 02:12:03 +0100 [thread overview]
Message-ID: <20110216011203.GA5773@linux-mips.org> (raw)
In-Reply-To: <4D5AFBCB.1090907@gmail.com>
On Tue, Feb 15, 2011 at 11:18:51PM +0100, Jiri Slaby wrote:
> > There, the res->start may be either of the following:
> > AR531X_WLAN0 .. 0x18000000
> > AR531X_WLAN1 .. 0x18500000
>
>
> > AR2315_WLAN0 .. 0xB0000000
>
> Or maybe this should be 0x10000000 in openwrt in the first place? Then
> ioremap should do the right thing, right?
Yes - 0xb0000000 looks like it's a virtual address which is wrong.
Rule #1: Put physical addresses in headers and code only.
Rule #2: If using one of the KSEG address and address conversion macros,
get rid of them, use ioremap. The KSEG macros are for use by arch core
code only; for use anywhere else I reject patches these days.
Ralf
next prev parent reply other threads:[~2011-02-16 1:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20110215220929.1cc6e9d4.nledovskikh@gmail.com>
[not found] ` <4D5AD6A6.8090505@gmail.com>
[not found] ` <AANLkTiks9rG2CzM2LabNerK3zgJ+R+weytQgvXxDbNe7@mail.gmail.com>
[not found] ` <4D5AE52B.80002@gmail.com>
[not found] ` <AANLkTinnCOEXF835yhNeJDfBdKjx_dss6TFeUmjL-Yk2@mail.gmail.com>
2011-02-15 22:16 ` [PATCH] ath5k: Use mips generic dma-mapping functions to avoid seqfault on AHB chips Jiri Slaby
2011-02-15 22:18 ` Jiri Slaby
2011-02-16 1:12 ` Ralf Baechle [this message]
2011-02-16 10:26 ` Nikolay Ledovskikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110216011203.GA5773@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jirislaby@gmail.com \
--cc=linux-mips@linux-mips.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=me@bobcopeland.com \
--cc=mickflemm@gmail.com \
--cc=nledovskikh@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox