From: Ralf Baechle <ralf@linux-mips.org>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: Jayachandran C <jayachandranc@netlogicmicro.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 1/7] Netlogic XLR/XLS processor IDs.
Date: Fri, 25 Mar 2011 13:58:20 +0100 [thread overview]
Message-ID: <20110325125819.GC18212@linux-mips.org> (raw)
In-Reply-To: <4D8C7C01.9080107@mvista.com>
On Fri, Mar 25, 2011 at 02:26:57PM +0300, Sergei Shtylyov wrote:
> >+static inline void cpu_probe_netlogic(struct cpuinfo_mips *c, int cpu)
> >+{
> >+ decode_configs(c);
> >+
> >+ c->options = (MIPS_CPU_TLB |
>
> Perhaps should align | with others...
>
> >+ MIPS_CPU_4KEX |
> >+ MIPS_CPU_COUNTER |
> >+ MIPS_CPU_DIVEC |
> >+ MIPS_CPU_WATCH |
> >+ MIPS_CPU_EJTAG |
> >+ MIPS_CPU_LLSC);
I reformatted that.
> [...]
> >+ default:
> >+ printk(KERN_INFO "Unknown Netlogic chip id [%02x]!\n",
>
> Not %04x?
I changed this into a panic call. An unknown CPU type means very little
chance for the system to actually succesfully boot the system.
Queued for 2.6.39. Thanks,
Ralf
next prev parent reply other threads:[~2011-03-25 12:58 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-25 4:56 [PATCH 0/7] Support for Netlogic XLR/XLS processors Jayachandran C
2011-03-25 4:57 ` [PATCH 1/7] Netlogic XLR/XLS processor IDs Jayachandran C
2011-03-25 11:26 ` Sergei Shtylyov
2011-03-25 12:58 ` Ralf Baechle [this message]
2011-03-25 13:19 ` Jayachandran C.
2011-03-25 13:44 ` Ralf Baechle
2011-03-25 4:57 ` [PATCH 2/7] mach-netlogic include directory and files Jayachandran C
2011-03-25 12:59 ` Ralf Baechle
2011-03-25 4:57 ` [PATCH 3/7] Cache, TLB support, and feature overrides for XLR Jayachandran C
2011-03-25 12:59 ` Ralf Baechle
2011-03-25 4:58 ` [PATCH 4/7] Add XLR to asm/module.h Jayachandran C
2011-03-25 12:59 ` Ralf Baechle
2011-03-25 4:58 ` [PATCH 5/7] Platform files for XLR/XLS processor support Jayachandran C
2011-03-25 13:02 ` Ralf Baechle
2011-03-25 4:58 ` [PATCH 6/7] Kconfig and Makefile update for Netlogic XLR/XLS Jayachandran C
2011-03-25 13:02 ` Ralf Baechle
2011-03-25 4:59 ` [PATCH 7/7] Add default configuration for XLR/XLS processors Jayachandran C
2011-03-25 13:03 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2011-03-18 13:27 [PATCH 0/7] Support for Netlogic " Jayachandran C
2011-03-18 13:28 ` [PATCH 1/7] Netlogic XLR/XLS processor IDs Jayachandran C
2011-03-16 11:56 [PATCH 0/7] Support for Netlogic XLR/XLS processors Jayachandran C
2011-03-16 11:57 ` [PATCH 1/7] Netlogic XLR/XLS processor IDs Jayachandran C
2011-03-16 12:01 ` Sergei Shtylyov
2011-03-16 13:24 ` Jayachandran C.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110325125819.GC18212@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=jayachandranc@netlogicmicro.com \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox