From: Alexander Clouter <alex@digriz.org.uk>
To: linux-mips@linux-mips.org
Cc: ralf@linux-mips.org, ddaney@caviumnetworks.com
Subject: [RFC|PATCH] MIPS: tlbex.c: Fix GCC 4.6.0 build error.
Date: Fri, 13 May 2011 16:49:42 +0100 [thread overview]
Message-ID: <20110513154941.GN25017@chipmunk> (raw)
For !HUGETLB_PAGE htlb_info barfs, and when !64BIT we get vmalloc_mode
grumbling.
CC arch/mips/mm/tlbex.o
arch/mips/mm/tlbex.c: In function 'build_r4000_tlb_refill_handler':
arch/mips/mm/tlbex.c:1155:22: error: variable 'vmalloc_mode' set but not used [-Werror=unused-but-set-variable]
arch/mips/mm/tlbex.c:1154:28: error: variable 'htlb_info' set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
Untested other than shovelling through a compiler, it really is turning
into an ifdef-fest though in there...
Signed-off-by: Alexander Clouter <alex@digriz.org.uk>
---
arch/mips/mm/tlbex.c | 17 ++++++++++++++++-
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/arch/mips/mm/tlbex.c b/arch/mips/mm/tlbex.c
index 04f9e17..814b3f4 100644
--- a/arch/mips/mm/tlbex.c
+++ b/arch/mips/mm/tlbex.c
@@ -1151,8 +1151,12 @@ static void __cpuinit build_r4000_tlb_refill_handler(void)
struct uasm_reloc *r = relocs;
u32 *f;
unsigned int final_len;
+#ifdef CONFIG_HUGETLB_PAGE
struct mips_huge_tlb_info htlb_info;
+#endif
+#ifdef CONFIG_64BIT
enum vmalloc64_mode vmalloc_mode;
+#endif
memset(tlb_handler, 0, sizeof(tlb_handler));
memset(labels, 0, sizeof(labels));
@@ -1163,13 +1167,24 @@ static void __cpuinit build_r4000_tlb_refill_handler(void)
scratch_reg = allocate_kscratch();
if ((scratch_reg > 0 || scratchpad_available()) && use_bbit_insns()) {
- htlb_info = build_fast_tlb_refill_handler(&p, &l, &r, K0, K1,
+#ifdef CONFIG_HUGETLB_PAGE
+ htlb_info =
+#else
+ (void)
+#endif
+ build_fast_tlb_refill_handler(&p, &l, &r, K0, K1,
scratch_reg);
+#ifdef CONFIG_64BIT
vmalloc_mode = refill_scratch;
+#endif
} else {
+#ifdef CONFIG_HUGETLB_PAGE
htlb_info.huge_pte = K0;
htlb_info.restore_scratch = 0;
+#endif
+#ifdef CONFIG_64BIT
vmalloc_mode = refill_noscratch;
+#endif
/*
* create the plain linear handler
*/
--
1.7.5.1
next reply other threads:[~2011-05-13 15:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 15:49 Alexander Clouter [this message]
2011-05-13 15:51 ` [RFC|PATCH] MIPS: tlbex.c: Fix GCC 4.6.0 build error Alexander Clouter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513154941.GN25017@chipmunk \
--to=alex@digriz.org.uk \
--cc=ddaney@caviumnetworks.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox