From: Alexander Clouter <alex@digriz.org.uk>
To: Sergei Shtylyov <sshtylyov@mvista.com>
Cc: linux-mips@linux-mips.org, florian@openwrt.org
Subject: Re: [PATCH] MIPS: AR7: Fix GCC 4.6.0 build error.
Date: Fri, 13 May 2011 16:50:30 +0100 [thread overview]
Message-ID: <20110513155030.GO25017@chipmunk> (raw)
In-Reply-To: <4DCD4EC9.1070804@mvista.com>
* Sergei Shtylyov <sshtylyov@mvista.com> [2011-05-13 19:31:21+0400]:
>
> >+ struct ar7_gpio_chip *gpch = (!ar7_is_titan())
>
> Parens around (!x) are not really necessary. Perhaps Ralf could
> remove them while applying...
>
I'm happy to resubmit if that is preferred.
Cheers
--
Alexander Clouter
.sigmonster says: BOFH excuse #267:
The UPS is on strike.
next prev parent reply other threads:[~2011-05-13 15:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-13 15:28 [PATCH] MIPS: AR7: Fix GCC 4.6.0 build error Alexander Clouter
2011-05-13 15:31 ` Sergei Shtylyov
2011-05-13 15:50 ` Alexander Clouter [this message]
2011-05-13 16:30 ` Ralf Baechle
2011-05-13 16:39 ` Ralf Baechle
2011-05-13 15:52 ` Florian Fainelli
2011-05-13 16:20 ` Jonas Gorski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110513155030.GO25017@chipmunk \
--to=alex@digriz.org.uk \
--cc=florian@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=sshtylyov@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox