From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 13 Jun 2011 06:28:00 +0200 (CEST) Received: from linux-sh.org ([111.68.239.195]:45657 "EHLO linux-sh.org" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1490946Ab1FME1y (ORCPT ); Mon, 13 Jun 2011 06:27:54 +0200 Received: from linux-sh.org (localhost.localdomain [127.0.0.1]) by linux-sh.org (8.14.4/8.14.4) with ESMTP id p5D4Oah7016184; Mon, 13 Jun 2011 13:24:36 +0900 Received: (from pmundt@localhost) by linux-sh.org (8.14.4/8.14.4/Submit) id p5D4OAHE009396; Mon, 13 Jun 2011 13:24:10 +0900 X-Authentication-Warning: linux-sh.org: pmundt set sender to lethal@linux-sh.org using -f Date: Mon, 13 Jun 2011 13:24:10 +0900 From: Paul Mundt To: Ralf Baechle Cc: Jesse Barnes , linux-pci@vger.kernel.org, Anton Vorontsov , Chris Metcalf , Colin Cross , "David S. Miller" , Eric Miao , Erik Gilling , Guan Xuetao , "H. Peter Anvin" , Imre Kaloz , Ingo Molnar , Ivan Kokshaysky , Krzysztof Halasa , Lennert Buytenhek , Matt Turner , Nicolas Pitre , Olof Johansson , Richard Henderson , Russell King , Thomas Gleixner , Andrew Morton , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mips@linux-mips.org, linux-sh@vger.kernel.org, linux-tegra@vger.kernel.org, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] PCI: Make the struct pci_dev * argument of pci_fixup_irqs const. Message-ID: <20110613042410.GB29731@linux-sh.org> References: <20110610143021.GA26043@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110610143021.GA26043@linux-mips.org> User-Agent: Mutt/1.4.1i X-archive-position: 30362 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: lethal@linux-sh.org Precedence: bulk X-list: linux-mips Return-Path: X-Keywords: X-UID: 10382 On Fri, Jun 10, 2011 at 03:30:21PM +0100, Ralf Baechle wrote: > Aside of the usual motivation for constification, this function has a > history of being abused a hook for interrupt and other fixups so I turned > this function const ages ago in the MIPS code but it should be done > treewide. > > Due to function pointer passing in varous places a few other functions > had to be constified as well. > > Signed-off-by: Ralf Baechle Acked-by: Paul Mundt