From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 24 Jun 2011 15:20:22 +0200 (CEST) Received: from moutng.kundenserver.de ([212.227.126.171]:60722 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S1490991Ab1FXNUR (ORCPT ); Fri, 24 Jun 2011 15:20:17 +0200 Received: from wuerfel.localnet (port-92-200-94-58.dynamic.qsc.de [92.200.94.58]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0LzDcL-1ReM1H2TZJ-014Vt0; Fri, 24 Jun 2011 15:20:06 +0200 From: Arnd Bergmann To: Ralf Baechle Subject: Re: [PATCH] SOUND: Fix non-ISA_DMA_API build failure Date: Fri, 24 Jun 2011 15:19:44 +0200 User-Agent: KMail/1.13.6 (Linux/3.0.0-rc1nosema+; KDE/4.6.3; x86_64; ; ) Cc: Mauro Carvalho Chehab , Jaroslav Kysela , Takashi Iwai , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-mips@linux-mips.org References: <20110623144750.GA10180@linux-mips.org> In-Reply-To: <20110623144750.GA10180@linux-mips.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201106241519.44425.arnd@arndb.de> X-Provags-ID: V02:K0:Kll31sZ2ObiCu49hsfRhNp+VFq5KUIHIy+HPy4gbzPf 5GNj551KAEJ72+2MP5jBr3yiq35+nmMZfybGa+KNquUkLe1PNC GW/NuUTzmGNHQVcyisEA46/GbDZbBT/bpUFEgVZa4bU8wZ96TQ 8pTWH8o6qDTWZDXifVy3dny/+0OUU3j88QjKT/OwP1EyExxrBn xPz4dzFz5T62f211859bQ== X-archive-position: 30510 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: arnd@arndb.de Precedence: bulk X-list: linux-mips Return-Path: X-Keywords: X-UID: 20314 On Thursday 23 June 2011 16:47:50 Ralf Baechle wrote: > Fixed by adding an explicit dependency on ISA_DMA_API for all of the > config statment that either result in the direction inclusion of code that > calls the ISA DMA API or selects something which in turn would use the ISA > DMA API. > > The sole ISA sound driver that does not use the ISA DMA API is the Adlib > driver so replaced the dependency of SND_ISA on ISA_DMA_API and add it to > each of the drivers individually. Do we really care all that much about the Adlib driver on platforms without ISA_DMA_API? Right now all of sound/isa/ is hidden behind ISA_DMA_API and I think that's acceptable > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index e4c97fd..0aeed28 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -168,7 +168,7 @@ config RADIO_MAXIRADIO > > config RADIO_MIROPCM20 > tristate "miroSOUND PCM20 radio" > - depends on ISA && VIDEO_V4L2 && SND > + depends on ISA && ISA_DMA_API && VIDEO_V4L2 && SND > select SND_ISA > select SND_MIRO > ---help--- Then this hunk by itself would be enough to solve the compile errors, AFAICT. Arnd