From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: alsa-devel@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Linux-MIPS <linux-mips@linux-mips.org>
Subject: Re: [PATCH V5 1/3] ASoC: Alchemy AC97C/I2SC audio support
Date: Tue, 26 Jul 2011 15:47:18 +0100 [thread overview]
Message-ID: <20110726144718.GJ7285@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <CAOLZvyFzHFGFvFrWigLi_oHpdQBp1ZCsRBEU8tF-62X8VaCd_Q@mail.gmail.com>
On Tue, Jul 26, 2011 at 04:43:16PM +0200, Manuel Lauss wrote:
> On Tue, Jul 26, 2011 at 4:31 PM, Mark Brown
> >> + case (~DMA_D0 & ~DMA_D1):
> >> + pr_debug("DMA %d empty irq.\n", stream->dma);
> > This case should return IRQ_NONE really since it didn't handle an
> > interrupt...
> If that last case ever happens the DMA engine is broken, as it shouldn't
> issue interrupts when no transfer is in progress. The errata sheets don't
> mention anything (yet).
In that case this should be an error rather than debug level print and
I'd say the IRQ_NONE thing definitely applies.
next prev parent reply other threads:[~2011-07-26 14:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-25 11:44 [PATCH V5 0/3] ASoC for Alchemy Au1000/1500/1100 Manuel Lauss
2011-07-25 11:44 ` [PATCH V5 1/3] ASoC: Alchemy AC97C/I2SC audio support Manuel Lauss
2011-07-26 14:31 ` Mark Brown
2011-07-26 14:43 ` Manuel Lauss
2011-07-26 14:47 ` Mark Brown [this message]
2011-07-25 11:44 ` [PATCH V5 2/3] ASoC: Add a DB1x00 AC97 machine driver Manuel Lauss
2011-07-26 14:39 ` Mark Brown
2011-07-27 14:56 ` Ralf Baechle
2011-07-27 18:11 ` Mark Brown
2011-07-25 11:44 ` [PATCH V5 3/3] ALSA: deprecate MIPS AU1X00 AC97 driver Manuel Lauss
2011-07-27 18:12 ` Mark Brown
2011-07-26 10:48 ` [PATCH V5 0/3] ASoC for Alchemy Au1000/1500/1100 Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110726144718.GJ7285@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=lrg@ti.com \
--cc=manuel.lauss@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox