From: Greg KH <gregkh@suse.de>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH 1/8] MIPS: Alchemy: abstract USB block control register access
Date: Fri, 12 Aug 2011 09:33:25 -0700 [thread overview]
Message-ID: <20110812163325.GA13018@suse.de> (raw)
In-Reply-To: <CAOLZvyFNoxjkU9bcdRtQA9Ey2wnsEN0MbRL3vmNeYhJZHMWoVQ@mail.gmail.com>
On Fri, Aug 12, 2011 at 06:20:48PM +0200, Manuel Lauss wrote:
> On Fri, Aug 12, 2011 at 6:04 PM, Greg KH <gregkh@suse.de> wrote:
> > On Fri, Aug 12, 2011 at 11:39:38AM +0200, Manuel Lauss wrote:
> >> Alchemy chips have one or more registers which control access
> >> to the usb blocks as well as PHY configuration. I don't want
> >> the OHCI/EHCI glues to know about the different registers and bits;
> >> new arch code hides the gory details of USB configuration from them.
> >>
> >> Cc: linux-usb@vger.kernel.org
> >> Cc: Greg Kroah-Hartman <gregkh@suse.de> (USB glue parts)
> >> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> >> ---
> >> CC'ed Greg for an Ack on the USB glue parts. I'd like this to go through the
> >> MIPS tree since other changes in it depend on it.
> >
> > Fine with me on the USB portions, you are just deleting code, which I
> > like :)
>
> Thanks!
>
>
> > But should the "common" USB code really live under arch/mips/alchemy/ ?
> > The goal is to move driver code out of arch/ and into drivers/. Why are
> > you moving stuff backwards here?
>
> This is just chip-dependent code for usb block and phy management, which
> varies wich chip subtype, the OHCI and EHCI controllers are identical on all
> of them. At the time moving the chip-depedent code to the other chip-dependent
> code seemed like a good idea...
But that's what drivers/* is, chip-dependent code. Please move it there
instead.
Has the MIPS developers learned nothing from the recent ARM mess? :)
greg k-h
next prev parent reply other threads:[~2011-08-12 17:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 9:39 [PATCH RESEND 0/8] MIPS: Alchemy updates Manuel Lauss
2011-08-12 9:39 ` [PATCH 1/8] MIPS: Alchemy: abstract USB block control register access Manuel Lauss
2011-08-12 9:39 ` Manuel Lauss
2011-08-12 16:04 ` Greg KH
2011-08-12 16:20 ` Manuel Lauss
2011-08-12 16:33 ` Greg KH [this message]
2011-08-12 17:25 ` Manuel Lauss
2011-08-12 17:27 ` Ralf Baechle
2011-08-12 9:39 ` [PATCH 2/8] MIPS: Alchemy: rewrite USB platform setup Manuel Lauss
2011-08-15 13:24 ` Ralf Baechle
2011-08-12 9:39 ` [PATCH 3/8] MIPS: Alchemy: more base address cleanup Manuel Lauss
2011-08-15 13:24 ` Ralf Baechle
2011-08-12 9:39 ` [PATCH 4/8] MIPS: au1xxx: au1xxx-ide: remove pb1200/db1200 header dep Manuel Lauss
2011-08-12 9:39 ` [PATCH 5/8] MIPS: Alchemy: clean DMA code of CONFIG_SOC_AU1??? defines Manuel Lauss
2011-08-18 19:12 ` Ralf Baechle
2011-08-12 9:39 ` [PATCH 6/8] MIPS: Alchemy: kill au1xxx.h header Manuel Lauss
2011-08-18 19:13 ` Ralf Baechle
2011-08-12 9:39 ` [PATCH 7/8] MIPS: Alchemy: redo PCI as platform driver Manuel Lauss
2011-08-15 13:25 ` Ralf Baechle
2011-08-12 9:39 ` [PATCH 8/8] MIPS: Alchemy: remove all CONFIG_SOC_AU1??? defines Manuel Lauss
2011-08-18 19:13 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812163325.GA13018@suse.de \
--to=gregkh@suse.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=manuel.lauss@googlemail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox