From: Greg KH <gregkh@suse.de>
To: Manuel Lauss <manuel.lauss@googlemail.com>
Cc: Linux-MIPS <linux-mips@linux-mips.org>,
Ralf Baechle <ralf@linux-mips.org>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH V2 1/8] MIPS: Alchemy: abstract USB block control register access
Date: Fri, 12 Aug 2011 11:42:27 -0700 [thread overview]
Message-ID: <20110812184227.GA17057@suse.de> (raw)
In-Reply-To: <1313172753-31088-1-git-send-email-manuel.lauss@googlemail.com>
On Fri, Aug 12, 2011 at 08:12:33PM +0200, Manuel Lauss wrote:
> Alchemy chips have one or more registers which control access
> to the usb blocks as well as PHY configuration. I don't want
> the OHCI/EHCI glues to know about the different registers and bits;
> new code hides the gory details of USB configuration from them.
>
> Cc: linux-usb@vger.kernel.org
> Cc: Greg Kroah-Hartman <gregkh@suse.de> (USB glue parts)
> Signed-off-by: Manuel Lauss <manuel.lauss@googlemail.com>
> ---
> V2: moved the chip-specific parts from arch home to usb/host/alchemy-common.c
>
> arch/mips/alchemy/common/dma.c | 12 +-
> arch/mips/alchemy/common/power.c | 42 ----
> arch/mips/include/asm/mach-au1x00/au1000.h | 84 ++------
> drivers/usb/host/Makefile | 1 +
> drivers/usb/host/alchemy-common.c | 337 ++++++++++++++++++++++++++++
> drivers/usb/host/ehci-au1xxx.c | 77 +------
> drivers/usb/host/ohci-au1xxx.c | 110 +--------
> 7 files changed, 382 insertions(+), 281 deletions(-)
> create mode 100644 drivers/usb/host/alchemy-common.c
Much nicer, thanks.
I can take this in the USB tree if the MIPS developers want, or if not,
feel free to add:
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
and take it through the MIPS tree.
greg k-h
next prev parent reply other threads:[~2011-08-12 18:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 18:12 [PATCH V2 1/8] MIPS: Alchemy: abstract USB block control register access Manuel Lauss
2011-08-12 18:12 ` Manuel Lauss
2011-08-12 18:42 ` Greg KH [this message]
2011-08-12 18:48 ` Manuel Lauss
2011-08-15 13:12 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110812184227.GA17057@suse.de \
--to=gregkh@suse.de \
--cc=linux-mips@linux-mips.org \
--cc=linux-usb@vger.kernel.org \
--cc=manuel.lauss@googlemail.com \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox