From: Greg KH <greg@kroah.com>
To: David Daney <david.daney@cavium.com>
Cc: rongqing.li@windriver.com, netdev@vger.kernel.org,
ralf@linux-mips.org, David Miller <davem@davemloft.net>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] staging/octeon: Software should check the checksum of no tcp/udp packets
Date: Mon, 26 Sep 2011 17:51:27 -0700 [thread overview]
Message-ID: <20110927005127.GB10447@kroah.com> (raw)
In-Reply-To: <4E80D794.3040701@cavium.com>
On Mon, Sep 26, 2011 at 12:50:44PM -0700, David Daney wrote:
> On 09/25/2011 06:08 PM, rongqing.li@windriver.com wrote:
> >From: Roy.Li<rongqing.li@windriver.com>
> >
> >Icmp packets with wrong checksum are never dropped since
> >skb->ip_summed is set to CHECKSUM_UNNECESSARY.
> >
> >When icmp packets with wrong checksum pass through the octeon
> >net driver, the not_IP, IP_exc, L4_error hardware indicators
> >show no error. so the driver sets CHECKSUM_UNNECESSARY on
> >skb->ip_summed.
> >
> >L4_error only works for TCP/UDP, not for ICMP.
> >
> >Signed-off-by: Roy.Li<rongqing.li@windriver.com>
>
> We found the same problem, but have not yet sent the patch to fix it.
>
> This looks fine to me,
>
> Acked-by: David Daney <david.daney@cavium.com>
>
> I would let davem, Ralf and Greg KH fight over who gets to merge it.
I'll let Ralf take it, unless he wants me to.
Ralf?
next prev parent reply other threads:[~2011-09-27 0:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 1:08 [PATCH] staging/octeon: Software should check the checksum of no tcp/udp packets rongqing.li
2011-09-26 1:08 ` rongqing.li
2011-09-26 19:50 ` David Daney
2011-09-27 0:51 ` Greg KH [this message]
2011-09-27 2:01 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110927005127.GB10447@kroah.com \
--to=greg@kroah.com \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=rongqing.li@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox