From: Ralf Baechle <ralf@linux-mips.org>
To: Hillf Danton <dhillf@gmail.com>
Cc: linux-mips@linux-mips.org,
"Jayachandran C." <jayachandranc@netlogicmicro.com>
Subject: Re: [PATCH 12/12] MIPS: Netlogic: Mark Netlogic chips as SMT capable
Date: Fri, 11 Nov 2011 13:49:06 +0000 [thread overview]
Message-ID: <20111111134906.GA12771@linux-mips.org> (raw)
In-Reply-To: <CAJd=RBA6OBq9PucheeAmzcphPRMPyDdwOOKQuQh7Lq7p37-g4A@mail.gmail.com>
On Fri, Nov 11, 2011 at 09:39:00PM +0800, Hillf Danton wrote:
> The patch was delivered by me, and reprepared under ideas and comments from
> you and Jayachandran, thanks. It was fine tuned, and SOB, by Jayachandran, and
> included in this patchset, which is far beyond my capability, for supporting
> Netlogic chips. And please reconsider the patchset.
This was just a comment on the mechanics of sending patches, not a review
of the patch itself - in fact I think it's fine.
What seems to have happened is that Jayachandran prepared the patches
with git-format-patch, then sent them out using mutt -H, not as the
authors of git had intended using git-send-email. Git-send-email
puts the sender's email address into the from header and inserts a From:
into the first line of the body, where needed.
On the receiving side it doesn't change a thing - the patch would have
looked exactly the same after being applied to git but as elaborated
before, there are other problems.
Ralf
next prev parent reply other threads:[~2011-11-11 13:49 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-11 11:37 [PATCH 00/12] MIPS: Support for Netlogic XLP processors Jayachandran C
2011-11-11 11:37 ` Jayachandran C
2011-11-11 11:37 ` [PATCH 01/12] MIPS: Netlogic: Style fixes for Platform Jayachandran C
2011-11-11 11:37 ` Jayachandran C
2011-11-16 0:46 ` Ralf Baechle
2011-11-11 11:37 ` [PATCH 02/12] MIPS: Netlogic: Use CPU_XLR instead of NLM_XLR Jayachandran C
2011-11-11 11:37 ` Jayachandran C
2011-11-16 0:46 ` Ralf Baechle
2011-11-11 11:37 ` [PATCH 03/12] MIPS: Netlogic: No need to set -Werror in mips/xlr Jayachandran C
2011-11-11 11:37 ` Jayachandran C
2011-11-16 0:46 ` Ralf Baechle
2011-11-11 11:38 ` [PATCH 04/12] MIPS: Netlogic: Move code common with XLP to common/ Jayachandran C
2011-11-11 11:38 ` Jayachandran C
2011-11-16 0:46 ` Ralf Baechle
2011-11-11 11:38 ` [PATCH 05/12] MIPS: Netlogic: Update default config Jayachandran C
2011-11-11 11:38 ` Jayachandran C
2011-11-16 0:47 ` Ralf Baechle
2011-11-11 11:39 ` [PATCH 06/12] MIPS: Netlogic: XLP CPU support Jayachandran C
2011-11-11 11:39 ` Jayachandran C
2011-11-16 0:47 ` Ralf Baechle
2011-11-11 11:39 ` [PATCH 07/12] MIPS: Netlogic: Add XLP platform files for XLP SoC Jayachandran C
2011-11-11 11:39 ` Jayachandran C
2011-11-16 0:47 ` Ralf Baechle
2011-11-11 11:39 ` [PATCH 08/12] MIPS: Netlogic: Add XLP makefiles and config Jayachandran C
2011-11-11 11:39 ` Jayachandran C
2011-11-16 0:47 ` Ralf Baechle
2011-11-11 11:40 ` [PATCH 09/12] MIPS: Netlogic: Add default XLP config Jayachandran C
2011-11-11 11:40 ` Jayachandran C
2011-11-16 0:47 ` Ralf Baechle
2011-11-11 11:40 ` [PATCH 10/12] MIPS: Netlogic: Merge some of XLR/XLP wakup code Jayachandran C
2011-11-11 11:40 ` Jayachandran C
2011-11-16 0:47 ` Ralf Baechle
2011-11-11 11:40 ` [PATCH 11/12] MIPS: Netlogic: Add support for XLP 3XX cores Jayachandran C
2011-11-11 11:40 ` Jayachandran C
2011-11-16 0:48 ` Ralf Baechle
2011-11-11 11:41 ` [PATCH 12/12] MIPS: Netlogic: Mark Netlogic chips as SMT capable Hillf Danton
2011-11-11 11:41 ` Hillf Danton
2011-11-11 12:54 ` Ralf Baechle
2011-11-11 13:38 ` Ralf Baechle
2011-11-11 13:39 ` Hillf Danton
2011-11-11 13:49 ` Ralf Baechle [this message]
2011-11-16 0:49 ` Ralf Baechle
-- strict thread matches above, loose matches on Subject: below --
2011-10-23 13:43 Hillf Danton
2011-10-23 13:43 ` Hillf Danton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111111134906.GA12771@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=dhillf@gmail.com \
--cc=jayachandranc@netlogicmicro.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox